On 11/01/23 13:17 +0100, Jeremie Courreges-Anglas wrote: > On Wed, Jan 11 2023, Robert Nagy <rob...@openbsd.org> wrote: > > On 10/01/23 18:41 +0100, Jeremie Courreges-Anglas wrote: > >> On Sun, Jan 08 2023, Jeremie Courreges-Anglas <j...@wxcvbn.org> wrote: > Hi, > > > No. Please keep the OpenBSD ifdef. > > This part is bugging me. #ifdef $OS is bad practice in my book, and > stdlib.h is the standard way to access malloc/calloc declarations > (malloc.h isn't). But hey, you're the maintainer, your call. ;)
The chromium patches are shared between OpenBSD and FreeBSD where malloc.h is available. Yes including stdlib.h would most probably work there as well, but that can be cleaned up later.