On 2023/01/07 22:06:23 +0100, Martin Reindl <mar...@catai.org> wrote:
> Hi,
> 
> attached is a new port for the ntfy (https://ntfy.sh/) server.
> 
> ntfy (pronounce: notify) is a simple HTTP-based pub-sub notification service.
> It allows you to send notifications to your phone or desktop via scripts from 
> any computer,
> entirely without signup or cost.
> 
> There is a free version of the service at ntfy.sh. There's also an open 
> source Android app
> (see Google Play or F-Droid), and an open source iOS app (see App Store).
> 
> Comments?

GH_* is not needed (usually) when using lang/go.  You need, however,
to set DISTNAME.  (GH_* sets DISTNAME too so that's why it was
working)

Instead of do-install, extra tasks can be done in post-install.

Needs @newgroup / @newuser in pkg/PLIST to create the user.

Locally I'm reusing the "_letskencrypt" uid whose the port was deleted
6 years ago (become acme-client in base.)

Index: user.list
===================================================================
RCS file: /home/cvs/ports/infrastructure/db/user.list,v
retrieving revision 1.414
diff -u -p -r1.414 user.list
--- user.list   29 Dec 2022 23:41:58 -0000      1.414
+++ user.list   8 Jan 2023 10:11:17 -0000
@@ -283,7 +283,7 @@ id  user            group           port
 772 _vault             _vault          security/vault
 773 _consul            _consul         sysutils/consul
 774 _facette           _facette        sysutils/facette
-#775 _letskencrypt     _letskencrypt   security/letskencrypt
+775 _ntfy              _ntfy           net/ntfy
 776 _ioq3              _ioq3           games/ioquake3
 777 _svnserve          _svnserve       devel/subversion
 778 _gitdaemon         _gitdaemon      devel/git


I'm inlining a diff to your Makefile and an updated tarball with the
changes applied.  (i've also taken the liberty to apply other minor
stylistic tweaks)

It seems to work locally, I can use `curl' to send notifications from
various hosts, but I'm having issue with the application (from
fdroid).  Very likely my fault, I'm testing this over wireguard and
with plain http, I'm probably missing something.

I'd change the default port and use something different from :8080.
It's handy to type and so likely to be already used (i have some
testing httpd servers listening on 8080 for example) but I don't have
a better suggestion.

If you're using it with relayd I guess it would be nice to ship a demo
config?  not required but can be nice to have :)

Anyway, the attached port is ok op@ to import if someone wants to.


  --- Makefile.orig     Sun Jan  8 10:45:25 2023
  +++ Makefile  Sun Jan  8 11:22:38 2023
  @@ -1,35 +1,32 @@
   COMMENT =    Send push notifications to your phone or desktop
   
  -MODGO_VERSION=       v1.30.1
  -MODGO_MODNAME=       heckel.io/ntfy
  -GH_ACCOUNT = binwiederhier
  -GH_PROJECT = ntfy
  -GH_TAGNAME = ${MODGO_VERSION}
  -HOMEPAGE =   https://ntfy.sh
  +MODGO_MODNAME =      heckel.io/ntfy
  +MODGO_VERSION =      v1.30.1
   
  -MAINTAINER = Martin Reindl <mar...@catai.org>
  +DISTNAME =   ntfy-${MODGO_VERSION}
   
   CATEGORIES = net
   
  +HOMEPAGE =   https://ntfy.sh
  +
  +MAINTAINER = Martin Reindl <mar...@catai.org>
  +
   # Apache-2.0/GPL-2.0
   PERMIT_PACKAGE =     Yes
   
   MODULES =    lang/go
   
   WANTLIB +=   c pthread
  -WRKDIST=     ${WRKSRC}
  +WRKDIST =    ${WRKSRC}
   
  -.include "modules.inc"
  -
  -# embed doc and app stubs
  +# stub doc and app html files; build fails because of failure to embed them.
   post-extract:
  -     mkdir ${WRKSRC}/server/site && \
  +     mkdir ${WRKSRC}/server/site
        touch ${WRKSRC}/server/site/app.html
  -     mkdir ${WRKSRC}/server/docs && \
  +     mkdir ${WRKSRC}/server/docs
        touch ${WRKSRC}/server/docs/index.html
   
  -do-install:
  -     ${MODGO_INSTALL_TARGET}
  +post-install:
        ${INSTALL_DATA_DIR} ${PREFIX}/share/examples/ntfy/
        ${INSTALL_DATA} ${WRKSRC}/server/server.yml \
                ${PREFIX}/share/examples/ntfy/
  @@ -38,4 +35,5 @@
        ${INSTALL_DATA} ${WRKSRC}/examples/$i/* ${PREFIX}/share/examples/ntfy/
   .endfor
   
  +.include "modules.inc"
   .include <bsd.port.mk>


Attachment: ntfy.tar.gz
Description: GNU Zip compressed data

Reply via email to