This diff looks good to me so ok daniel@ for it to be committed. But a few notes online below.
> On Jan 7, 2023, at 8:11 AM, Volker Schlecht <openbsd-po...@schlecht.dev> > wrote: > > Updates findlib to 1.9.6 in preparation for an eventual / possible / future > update of OCaml. Please make sure to send diff to maintainer so they can have a chance to weigh in. In the future I think you should say what testing was done. I built all the reverse dependencies on my end and also checked the two ports that have runtime deps on findlib. > > * Does not add a build dependency on ocamlbuild - it took me a while to > figure out where I screwed up there ... I think this deserves an explanation in the commit of why we need to do an update of findlib in order to support ocaml 4.13 or later. > * The FAKE_FLAGS lead to fake installing into the wrong directory with 1.9.6 This is mentioned in the changes for findlib 1.9.4 that proper DESTDIR support was added. I think this should be mentioned in the commit. Your explanation above is not complete. > * update-plist removed the @bin markers from PFRAG.dynlink-native, and I'm > not sure why they used to be there in the first place. > <findlib-1.9.6.diff> Fine with me.
