With the attached patch, node builds and works for me on my freshly
dedicated i386 build machine and on amd64.
On 1/4/23 07:26, Barry K. Nathan wrote:
On Tue, Jan 3, 2023 at 4:20 PM Volker Schlecht
<openbsd-po...@schlecht.dev> wrote:
Looping in Barry since he reportedly had the build working on i386, in
the hope that he can remember the missing puzzle piece.
I'll look at this when I get a chance, but that may not be until
the weekend, unfortunately. (In addition to other stuff I need to
get done over the next couple of days, one of my computers just
failed and I need to get that situation under control.)
Index: Makefile
===================================================================
RCS file: /cvs/ports/lang/node/Makefile,v
retrieving revision 1.112
diff -u -p -r1.112 Makefile
--- Makefile 29 Dec 2022 23:34:13 -0000 1.112
+++ Makefile 4 Jan 2023 14:37:52 -0000
@@ -10,6 +10,7 @@ PLEDGE_VER = 1.1.3
DISTFILES = node-pledge-{}${PLEDGE_VER}.tar.gz:0 \
${DISTNAME}-headers.tar.gz \
${DISTNAME}.tar.xz
+REVISION = 0
DISTNAME = node-${NODE_VERSION}
PKGNAME = ${DISTNAME:S/v//g}
Index: patches/patch-deps_v8_src_base_atomicops_h
===================================================================
RCS file: /cvs/ports/lang/node/patches/patch-deps_v8_src_base_atomicops_h,v
retrieving revision 1.5
diff -u -p -r1.5 patch-deps_v8_src_base_atomicops_h
--- patches/patch-deps_v8_src_base_atomicops_h 3 Jan 2023 12:10:40 -0000 1.5
+++ patches/patch-deps_v8_src_base_atomicops_h 4 Jan 2023 14:37:52 -0000
@@ -14,3 +14,21 @@ Index: deps/v8/src/base/atomicops.h
using Atomic64 = int64_t;
#else
using Atomic64 = intptr_t;
+@@ -257,7 +257,7 @@ inline Atomic32 SeqCst_Load(volatile const Atomic32* p
+ std::memory_order_seq_cst);
+ }
+
+-#if defined(V8_HOST_ARCH_64_BIT)
++#if defined(V8_HOST_ARCH_64_BIT) || defined(V8_OS_OPENBSD)
+
+ inline Atomic64 Relaxed_CompareAndSwap(volatile Atomic64* ptr,
+ Atomic64 old_value, Atomic64 new_value) {
+@@ -468,7 +468,7 @@ inline int Relaxed_Memcmp(volatile const Atomic8* s1,
+
+ // On some platforms we need additional declarations to make
+ // AtomicWord compatible with our other Atomic* types.
+-#if defined(V8_OS_DARWIN) || defined(V8_OS_OPENBSD) || defined(V8_OS_AIX)
++#if defined(V8_OS_DARWIN) || defined(V8_OS_AIX)
+ #include "src/base/atomicops_internals_atomicword_compat.h"
+ #endif
+
