On 2022/11/22 23:17:13 +0100, "Gonzalo L. Rodriguez" <[email protected]> wrote:
> Hi,
> 
> This is a port for this cute minimalist file manager called "llama":
> 
> https://github.com/antonmedv/llama
> 
> OK? Comments?

the makefile can be simplified a bit:

 - PKGNAME is not needed

 - V also is not needed, you can just have MODGO_VERSION=v1.2.0 and
   DISTNAME=llama-${MODGO_VERSION}.  go.port.mk will turn it into
   PKGNAME=llama-1.2.0 automatically.

 - it's missing WANTLIB += c pthread

OK op@ with these fixed.

I'd also rewrite the DESCR so it's not spoken in first person, but
this is opninable.  I propose:

: llama is a simple and minimalistic file manager.  It's a fast way to
: navigate the filesystem, and a cd and ls replacement.  It allows for
: quick navigation with fuzzy searching and the cd-integration with the
: shell is a one-liner.


I got so disappointed to review yet another port without a manpage
that I felt the urge to write one, especially because the program is
small and I'm liking it.  Thus I'm attaching an updated tarball with
the previously mentioned point addressed and with a manpage in
files/llama.1.  I'll also try to upstreaming it.

Feel free to ignore me and my ravings.

Attachment: llama.tar.gz
Description: GNU Zip compressed data

Reply via email to