On 2022/11/21 12:11:24 -0800, "Heppler, J. Scott" <shep...@spectrum.net> wrote: > I debated breaking the port down into flavors but really did not have a > sense about what OpenBSD users would use. Personally, the lightest > fastest option is what I would use. > > Since --with-lx is the default, it will throw a build error.
Hum, I don't follow you here. For me it builds fine, and since --with-lx is not the default the configure script doesn't even try to look for menu-cache (which is great!) I guess that the pmenu is similarly disabled because it wasn't enabled at via a configure switch. > I'm not > sure what OpenBSD policy is toward a "multi-tool" port that does not > install with all needed dependencies for each one its "tools". it really depends. In a case like this however if we want to enable pmenu and lx I'd just enable them in the configure and add a RUN_DEPENDS for pmenu. jgmenu already has a RUN_DEPENDS on desktop-file-utils and x11/gtk+3, so pmenu is not a big addition. however, both pmenu and lx was moved to contrib/ in favour of the new menu generator since 4.0, that's why I'd just use that. From some quick testing it seems to work just as fine as menu-cache, and it's also the default now... > If I > recall correctly, the README arose to indicate -lx needed the > installation of menu-cache and gnome/mate menu packages. Perhaps just > distilling the README down to a man page reference and the need for > gnome/mate menus apps/lx and menu-cache for lx itself? Nope, it did not. We have some package that has optional dependency that is used only at runtime but it's considered hardly useful or too big for most cases and so it's documented in the readme. (see the readme of devel/git for example.) if this were the case for jgmenu I wouldn't object, but it's not. > I've been using -apps, via my own builds and in Arch for several years - I > think it is fairly mature. It also has the fewest dependencies so it > essentially makes lx and pymenu obsolete. > > In addition to the other changes, I'd like to try to split the port into > jgmenu and jgmenu-apps. I'm an occasional porter and this will be my > 1st attempt at flavors. Humm... I'm not sure. Why should it be splitted in jgmenu and jgmenu-apps? (what could be useful to package separately, and MULTI_PACKAGES would help, is the xfce4 panel applet, that would be interesting.) > Last question > https://www.openbsd.org/faq/ports/guide.html#Ideal > Suggested CONFIGURE+STYLE = gnu - will "simple" work with > MULTI_PACKAGES/FLAVORS ? Yes, it will work. CONFIGURE_STYLE just tells the port infrastructure how to do one step of the building, FLAVORS is a way to control what to build and MULTI_PACKAGES a way to specify which things ends up in which package; they're all different mechanisms more or less independent.
