On 15/11/22 14:56 +0000, Sergey A. Osokin wrote: > Hi, > > On Thu, Oct 27, 2022 at 01:58:01PM +0000, Sergey A. Osokin wrote: > > > > [...] > > Could you please provide an update. > Thank you. > > -- > Sergey A. Osokin
Hi I've looked into your diff and there are a lot of issues that needs to be fixed, so please address these first: - this is not freebsd, there is no PORTREVISION, so why did you add it? - you do an update but you forgot to remove REVISION-main - rearringing variables in an alphabetical order is nice, but completely useless in this case and it also makes the diff harder to read - the distfile for the njs module is added, some variables are configured for it but then you don't actually enable the module, so it never get built (this module also has to be dynamic) - missing plist and descr for the new module Thanks -- Regards, Robert Nagy
