On Fri Nov 18, 2022 at 02:14:07PM +0000, Edd Barrett wrote: > On Thu, Nov 17, 2022 at 11:04:07PM +0000, Laurence Tratt wrote: > > @@ -62,7 +62,7 @@ BUILD_DEPENDS = ${RUN_DEPENDS} \ > > LIB_DEPENDS = devel/gettext,-runtime \ > > devel/libtermkey \ > > devel/libuv \ > > - devel/libvterm \ > > + devel/libvterm=0.3 \ > > I'd make that a >= constraint for future proofing.
Yes please. > > > +# Test_language_cmd fails due to > > +# https://github.com/neovim/neovim/issues/19331 > > +# > > # If cscope is installed, one test fails: > > # https://github.com/neovim/neovim/issues/12744 > > Minor nitpick, put a colon on the end of the line ending "due to" for > consistency with the other comment. > > Otherwise LGTM. Anyone else have any inputs or OKs? > ok rsadowski