Landry Breuil wrote (2022-11-14 09:14 CET):
> Le Mon, Nov 14, 2022 at 08:44:07AM +0100, Stefan Hagen a écrit :
> > Caspar Schutijser wrote (2022-11-13 20:20 CET):
> > > Hi,
> > > 
> > > Below is a diff that updates Tor Browser to 12.0a4. The diff is a bit
> > > big since upstream shuffled some stuff around (in particular related to
> > > Tor Launcher). Tested on amd64.
> > > 
> > > Comments or OKs?
> > > 
> > > Caspar
> > 
> > The WANTLIBs still look a bit strange here:
> > 
> > > # uses pledge()
> > > # Extra:  Xcomposite.4 Xdamage.4 Xfixes.6 gdk-x11-2.0.2400 
> > > gtk-x11-2.0.2400
> > > WANTLIB += Xrandr Xt gthread-2.0 pangoft2-1.0
> > 
> > I get:
> > Extra:  Xcomposite.4 Xcursor.5 Xdamage.4 Xfixes.6 Xi.12 Xrender.6
> > Extra:  Xt.11 gthread-2.0.4200 pangoft2-1.0.3801
> > 
> > If the ones you added are really needed, they should be mentioned in the 
> > "Extra:" comment as well.
> > 
> > www/firefox-esr only has: WANTLIB += Xrandr Xtst, so I'm wondering if 
> > this list is right.
> 
> I've moved most of the common wantlibs to mozilla.port.mk last month, cf
> https://github.com/openbsd/ports/commit/1f57d683037506321a3981f5ea80da2e8d8090a5
> 
> at the time tor browser wasnt building at all, so i havent been able to
> check what was the actual wantlib for it.
> 
> it's sad of tor-browser doesnt follow along other mozilla ports here, it
> should normally have the same WANTLIB as the corresponding esr port...
> Dunno what they'd do. Not a huge deal anyway.

I successfully built it with:

WANTLIB += Xrandr

and got:

Extra:  Xcomposite.4 Xcursor.5 Xdamage.4 Xfixes.6 Xi.12 Xrender.6

I think WANTLIB can be reduced to just Xrandr.

Best Regards,
Stefan

Reply via email to