On Sun, Nov 13, 2022 at 05:53:41PM +0100, Christian Weisgerber wrote:
> We have a number of ports that set CONFIGURE_STYLE=none. On its own,
> that doesn't mean anything. "none" is not a defined CONFIGURE_STYLE.
> If a port should not attempt to run a configure script, simply don't
> set CONFIGURE_STYLE at all.
>
> That said, both the perl and python modules use CONFIGURE_STYLE=none
> for their own purposes. Some ports also pick up a CONFIGURE_STYLE
> setting from Makefile.inc and then use "none" to explicitly disable
> it.
>
> That leaves a number of ports that set CONFIGURE_STYLE=none for no
> reason. I would like to remove it from those, to keep the pattern
> from spreading. The comment in osinfo-db is obsolete. I verified
> that these ports build just fine with the line removed.
>
> OK?
OK
>
> Index: devel/fpm/Makefile
> ===================================================================
> RCS file: /cvs/ports/devel/fpm/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- devel/fpm/Makefile 8 Nov 2022 16:12:02 -0000 1.1.1.1
> +++ devel/fpm/Makefile 13 Nov 2022 16:25:30 -0000
> @@ -39,8 +39,6 @@ TEST_DEPENDS += devel/git,-main
>
> SEPARATE_BUILD = Yes
>
> -CONFIGURE_STYLE = none
> -
> MAKE_ENV += FPM_FC="${MODFORTRAN_COMPILER}" \
> FPM_FFLAGS="${FFLAGS}" \
> FPM_CC="${CC}" \
> Index: games/jumpnbump/Makefile
> ===================================================================
> RCS file: /cvs/ports/games/jumpnbump/Makefile,v
> retrieving revision 1.7
> diff -u -p -r1.7 Makefile
> --- games/jumpnbump/Makefile 11 Mar 2022 19:04:35 -0000 1.7
> +++ games/jumpnbump/Makefile 13 Nov 2022 16:26:36 -0000
> @@ -22,8 +22,6 @@ LIB_DEPENDS = archivers/bzip2 \
>
> RUN_DEPENDS = devel/desktop-file-utils
>
> -CONFIGURE_STYLE = none
> -
> USE_GMAKE = Yes
>
> FAKE_FLAGS = DESTDIR=
> Index: games/zelda3/Makefile
> ===================================================================
> RCS file: /cvs/ports/games/zelda3/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- games/zelda3/Makefile 12 Nov 2022 09:58:29 -0000 1.1.1.1
> +++ games/zelda3/Makefile 13 Nov 2022 16:26:39 -0000
> @@ -21,7 +21,6 @@ WANTLIB = c m SDL2
> LIB_DEPENDS = devel/sdl2
>
> USE_GMAKE = Yes
> -CONFIGURE_STYLE = none
> ALL_TARGET = zelda3
>
> pre-build:
> Index: games/zelda3-sprites/Makefile
> ===================================================================
> RCS file: /cvs/ports/games/zelda3-sprites/Makefile,v
> retrieving revision 1.1.1.1
> diff -u -p -r1.1.1.1 Makefile
> --- games/zelda3-sprites/Makefile 12 Nov 2022 10:01:08 -0000 1.1.1.1
> +++ games/zelda3-sprites/Makefile 13 Nov 2022 16:26:44 -0000
> @@ -14,7 +14,6 @@ HOMEPAGE = https://snesrev.github.io/spr
> PERMIT_PACKAGE = no license
> PERMIT_DISTFILES = ${PERMIT_PACKAGE}
>
> -CONFIGURE_STYLE = none
> NO_BUILD = Yes
>
> do-install:
> Index: lang/go/Makefile
> ===================================================================
> RCS file: /cvs/ports/lang/go/Makefile,v
> retrieving revision 1.126
> diff -u -p -r1.126 Makefile
> --- lang/go/Makefile 17 Oct 2022 18:06:21 -0000 1.126
> +++ lang/go/Makefile 13 Nov 2022 16:26:54 -0000
> @@ -29,7 +29,6 @@ DISTFILES = ${DISTNAME}${EXTRACT_SUFX}
> BUILD_DEPENDS = shells/bash
>
> SEPARATE_BUILD = Yes
> -CONFIGURE_STYLE = None
> SUBST_VARS = GOCFG
>
> PSEUDO_FLAVORS = native_bootstrap
> Index: lang/zig/Makefile
> ===================================================================
> RCS file: /cvs/ports/lang/zig/Makefile,v
> retrieving revision 1.14
> diff -u -p -r1.14 Makefile
> --- lang/zig/Makefile 10 Mar 2022 13:36:49 -0000 1.14
> +++ lang/zig/Makefile 13 Nov 2022 16:26:49 -0000
> @@ -39,8 +39,6 @@ BUILD_DEPENDS += devel/cmake \
>
> SEPARATE_BUILD = Yes
>
> -CONFIGURE_STYLE = none
> -
> MAKE_ENV += CXXFLAGS="${CXXFLAGS}" \
> MAKE_JOBS="${MAKE_JOBS}" \
> WRKSRC="${WRKSRC}" \
> Index: misc/osinfo/osinfo-db/Makefile
> ===================================================================
> RCS file: /cvs/ports/misc/osinfo/osinfo-db/Makefile,v
> retrieving revision 1.57
> diff -u -p -r1.57 Makefile
> --- misc/osinfo/osinfo-db/Makefile 21 Oct 2022 09:24:35 -0000 1.57
> +++ misc/osinfo/osinfo-db/Makefile 13 Nov 2022 16:28:08 -0000
> @@ -12,8 +12,6 @@ USE_GMAKE= No
>
> BUILD_DEPENDS= misc/osinfo/osinfo-db-tools
>
> -CONFIGURE_STYLE= none # !meson
> -
> do-install:
> osinfo-db-import --root ${WRKINST} --dir ${TRUEPREFIX}/share/osinfo \
> ${FULLDISTDIR}/${DISTFILES}
> Index: misc/rocrail/Makefile
> ===================================================================
> RCS file: /cvs/ports/misc/rocrail/Makefile,v
> retrieving revision 1.23
> diff -u -p -r1.23 Makefile
> --- misc/rocrail/Makefile 8 Nov 2022 11:14:53 -0000 1.23
> +++ misc/rocrail/Makefile 13 Nov 2022 16:27:00 -0000
> @@ -32,7 +32,6 @@ LIB_DEPENDS-gui += x11/wxWidgets>=3.0.4
> RUN_DEPENDS-gui += ${PKGPATH},-main
>
> USE_GMAKE = Yes
> -CONFIGURE_STYLE = none
> MAKE_ENV = CC="${CC}" CXX="${CXX}"
> MAKE_FILE = makefile
> MAKE_FLAGS = PLATFORM=OPENBSD
> Index: sysutils/checkrestart/Makefile
> ===================================================================
> RCS file: /cvs/ports/sysutils/checkrestart/Makefile,v
> retrieving revision 1.4
> diff -u -p -r1.4 Makefile
> --- sysutils/checkrestart/Makefile 10 Mar 2022 16:24:38 -0000 1.4
> +++ sysutils/checkrestart/Makefile 13 Nov 2022 16:28:14 -0000
> @@ -20,8 +20,6 @@ WANTLIB = c kvm>=16.2
> MAKE_ENV = BINDIR=${LOCALBASE}/sbin \
> MANDIR=${LOCALBASE}/man/man
>
> -CONFIGURE_STYLE = none
> -
> NO_TEST = Yes
>
> .include <bsd.port.mk>
> --
> Christian "naddy" Weisgerber na...@mips.inka.de
>
--
Antoine
