Hi, > On Fri, Oct 21, 2022, at 3:23 PM, Edd Barrett wrote: >> On Fri, Oct 21, 2022 at 05:50:08PM +0200, Laurent Cheylus wrote: >> - add patch for Bash completion for kill command (kill **) > > Did you author this patch, or did it come from somewhere? If we > borrowed it, we should link to it at the top of the diff.
I'm the author of this patch. I have already opened an issue upstream https://github.com/junegunn/fzf/issues/2714 but no response. I will propose a pull request on GitHub to fix it (if accepted). >> +MODGO_VERSION = v0.0.0-20220928142231-04d0b0223fd6 > > I'm a total go noob. When updating this port in the future, where will > I get that magic version string from? I think this all comes about > because upstream are not using proper semantic versioning, right? Yes, upstream packages for fzf are not using proper semantic versioning. That's why there are different values for MODGO_VERSION and V (version) variables in my Makefile. As explained by Aaron, to get MODGO_VERSION, you can use `go list -m` command : $ go list -m github.com/junegunn/fzf@0.34.0 github.com/junegunn/fzf v0.0.0-20220928142231-04d0b0223fd6 Thanks for your review. Laurent
