On Fri Oct 14, 2022 at 12:34:37PM +0200, Omar Polo wrote: > Hello, > > On 2022/10/14 11:25:48 +0200, Róbert Bagdán <kikadf...@gmail.com> wrote: > > Hi! > > > > I've attached the port of x11/copyq, which is a Qt5 based advanced > > clipboard manager with powerful editing and scripting features. > > > > I built without problem on amd64 -current and -stable, but I tested only > > -stable, works fine. > > some minor nits, but otherwise looks good: > > - the license is actually GPLv3+ due to the "or any later version" > clausole in the source files. > > - base-gcc can't deal with gnu++17, and shouldn't be used on gcc > arches for c++ most of the times anyway, so drop that and add a > comment about the C++ version before the COMPILER line.
I'm quite sure this port use the qt5 module, please remove COMPILER it will be set by the module. > > - Usually RUN/LIB_DEPENDS are written without +=, it doesn't really > matter but it's the style you'd find in other ports too so let's be > consistent. > > - make update-plist removes some directories already provided by > other ports from the PLIST > > - it tries to use git at configure time to discover the commit id of > the build. seems to be avoidable by setting GITHUB_SHA; we could > just snag the commit id of the release, but i'm lazy went with > "unknown" :) > The about seems to only show the version anyway. > > very lightly tested, but seems to work fine! > > I'm attacching an updated tarball with these points fixed that's ok > for me to import. > > > Thanks > > Omar Polo > >
