On 2022/10/08 08:18:54 +0000, Laurent Cheylus <f...@free.fr> wrote:
> On Sat, 8 Oct 2022 08:10:26 -0000 (UTC), Laurent Cheylus wrote:
>
> > Attached a diff on CVS for 0.34.0 version.
works fine for my limited usage (fzf-tmux with a custom script, not
much.)
Thanks!
two nitpicks, otherwise it's ok for me!
> --- Makefile 11 Mar 2022 19:57:26 -0000 1.13
> +++ Makefile 8 Oct 2022 07:44:36 -0000
> @@ -1,9 +1,10 @@
> COMMENT = command-line fuzzy finder
>
> -# Note: we make our own vendored distfile as upstream doesn't do semantic
> -# versioning. Use 'go mod vendor'.
> -DISTNAME = fzf-0.24.1
> -REVISION = 2
> +MODGO_MODNAME = github.com/junegunn/fzf
Here I'd use a tab after the '=' instead of a space
> +MODGO_VERSION = v0.0.0-20220928142231-04d0b0223fd6
> +
> +V = 0.34.0
and here two tabs so it lines up with DISTNAME.
> +DISTNAME = fzf-${V}
No need to send it again, it's just spacing that who commits can
easily adjust.
Cheers,
Omar Polo
