Omar Polo <o...@openbsd.org> wrote: > Hello, > > "mdw" <m...@sdf.org> wrote: > > Hi, > > > > Nicotine+ is a graphical client for the Soulseek peer-to-peer network. > > https://github.com/nicotine-plus/nicotine-plus > > > > Over a year ago v3.0.0 was submitted to ports@, but didn't get any response > > https://marc.info/?l=openbsd-ports&m=161310210623977&w=2 > > > > Here is an updated version 3.2.2, apologies if anything looks funny it is > > my first time working with ports. > > it's not bad, there are just a couple of things to adjust but it's a > solid first submission :) > > > I tested briefly search/chat rooms/transfers on my system running -current > > and it seems to work fine. All of the hard work was done with the original > > submission I just updated a few things. > > > > Thanks, > > Matthew > > some nits: > > - we've dropped the RCS Ids (the $OpenBSD$ line) in ports > - i'd set CATEGORIES, HOMEPAGE and MAINTAINER after GH_* as per > Makefile.template > - no need to set MODPY_VERSION, that's already the default > > Personally, I'd go with a patch instead of sed -i for setup.py, but even > using sed -i should be fine in this case. (patches are more robust than > sed for updates; they break sometimes, but at least you get the chance > to see what's going on instead of blindling substituting.) > > I'm attaching a diff against your Makefile with those nit fixed and an > updated tarball. I haven't really run-tested it more than clicking > around in the GUI (didn't want to mess around with the firewall atm) but > the port looks good and (assuming it works) it's OK op@ to import if > someone wants to. > > (+cc Han, the previous submitter) > > #application/x-gzip: /tmp/nicotine-plus.tar.gz
wops, forgot to actually attach the updated port... while here i've dropped Han as maintainer, feel free to add yourself :)
nicotine-plus.tar.gz
Description: GNU Zip compressed data
