Timo Myyrä <timo.my...@bittivirhe.fi> wrote: > Timo Myyrä <timo.my...@bittivirhe.fi> [2022-07-18, 09:19 +0300]: > > > Stuart Henderson <s...@spacehopper.org> [2022-07-16, 10:00 +0100]: > > > >> Quick comments: > >> > >> - if the Java version needs to be kept in sync with jna, it would be > >> worth adding a comment to jna mentioning that
I guess Stuart meant something like this Index: Makefile =================================================================== RCS file: /home/cvs/ports/java/jna/Makefile,v retrieving revision 1.33 diff -u -p -r1.33 Makefile --- Makefile 26 May 2022 08:30:30 -0000 1.33 +++ Makefile 24 Jul 2022 07:38:32 -0000 @@ -12,6 +12,8 @@ HOMEPAGE= https://github.com/java-native PERMIT_PACKAGE= Yes MODULES= java + +# keep in sync with lang/abcl MODJAVA_VER= 11 MODJAVA_BUILD= ant > >> - pkg/README is supposed to use a standard format with the header text. > >> Or there's probably not much downside to adding a tub dependency on > >> jna and getting rid of the readme. > >> > >> - up to you as maintainer what to do for tests, seems you have picked a > >> sensible way to handle it to me. Tests are not run in bulk builds. > > > > > > Here's another attempt at this: > > - add bash as build dependency and use it to generate abcl.properties > > - remove the patches for getting the java tests to run > > - remove README and add jna as run dependency > > - add mention to about syncing MODJAVA_VER with jna > > > > I removed the test setup, a bit too much patching for just running 16 > > tests. Perphaps easier to just run tests separately as needed. > > > > timo > > [...] > ping... seems to work fine; committed, thanks!
