On 2022/07/18 01:34, Pavel Korovin wrote:
> Port for pgBackRest, PostgreSQL backup & restore tool.
> OK to import?

I'd make a small tweak to drop DIST_SUBDIR, mostly so that I can use
"cd /usr/ports/*/portname" to avoid having to remember/find the category,
see the DISTFILES/DIST_SUBDIR change in the diff below.

Other tweaks: libiconv doesn't seem to be used, there are some extra
WANTLIB, also no need for a separate BUILD_DEPENDS on postgresql because
it's already pulled in via LIB_DEPENDS

OK with this

diff --git a/databases/pgbackrest/Makefile b/databases/pgbackrest/Makefile
index 1eb4551..75d7f7d 100644
--- a/databases/pgbackrest/Makefile
+++ b/databases/pgbackrest/Makefile
@@ -11,23 +11,20 @@ MAINTAINER =                Pavel Korovin <p...@openbsd.org>
 PERMIT_PACKAGE =       Yes
 
 MASTER_SITES =         
https://github.com/pgbackrest/pgbackrest/archive/release/
-DISTFILES =            ${V}.tar.gz
-DIST_SUBDIR =          pgbackrest
+DISTFILES =            pgbackrest-{}${V}.tar.gz
 
 WRKDIST =              ${WRKDIR}/pgbackrest-release-${V}
 WRKSRC =               ${WRKDIST}/src
 
-WANTLIB +=             bz2 c crypto iconv lz4 lzma m pq pthread ssl xml2 z zstd
+WANTLIB +=             bz2 c crypto lz4 pq ssl xml2 z zstd
 
-BUILD_DEPENDS =                devel/libyaml \
-                       databases/postgresql,-main
+BUILD_DEPENDS =                devel/libyaml
 
 RUN_DEPENDS =          databases/postgresql,-server
 
 LIB_DEPENDS =          archivers/bzip2 \
                        archivers/lz4 \
                        archivers/zstd \
-                       converters/libiconv \
                        databases/postgresql \
                        textproc/libxml
 
diff --git a/databases/pgbackrest/distinfo b/databases/pgbackrest/distinfo
index 7ee35f3..2d00366 100644
--- a/databases/pgbackrest/distinfo
+++ b/databases/pgbackrest/distinfo
@@ -1,2 +1,2 @@
-SHA256 (pgbackrest/2.39.tar.gz) = 0cZBJxu767etrnK+JHFr8ClfdG0aAMXwpjLq12abGo0=
-SIZE (pgbackrest/2.39.tar.gz) = 5771539
+SHA256 (pgbackrest-2.39.tar.gz) = 0cZBJxu767etrnK+JHFr8ClfdG0aAMXwpjLq12abGo0=
+SIZE (pgbackrest-2.39.tar.gz) = 5771539

Reply via email to