On 2022/06/09 14:10, Sergey A. Osokin wrote: > On Wed, Jun 08, 2022 at 06:12:56PM +0100, Stuart Henderson wrote: > > On 2022/06/08 18:57, Omar Polo wrote: > > > Stuart Henderson <s...@spacehopper.org> wrote: > > > > On 2022/06/07 21:11, Omar Polo wrote: > > > > > > > > > > nginx-lua-1.22.0p0(www/nginx,-lua): > > > > > Missing: luajit-5.1.1 from luajit-2.0.5pl20210608 > > > > > (/var/www/modules/ngx_http_lua_module.so) > > > > > WANTLIB += luajit-5.1 > > > > > > > > it wouldn't be ideal to restrict building nginx to only archs which > > > > have luajit > > > > > > openresty/lua-nginx-module upstream moved to luajit from 0.10.16 onward, > > > see for e.g.: > > > > > > https://github.com/openresty/lua-nginx-module/commit/d154e5a7c1cbb7810d0224862e577fc8a6b8e3ac > > > > The luajit 2.0 branch in ports is only for 32-bit arm, amd64, i386, powerpc > > so it misses some important archs. > > > > The upstream 2.1 branch adds arm64 but still not sparc64 and some others. > > > > I think ngx_http_lua_module build will need to be arch-dependent then, > > we don't really want to block nginx build on arm64 and sparc64. > > > > (Looking at https://github.com/openresty/lua-nginx-module it is probably > > also best to fetch github.com/openresty/luajit2 as an additional distfile > > and build with that version instead though that's probably best looked > > at as an extra step later.) > > Is that possible to check an arch during the build and in case it's > sparc64 platform use lang/lua and lang/luajit-openresty (yes, another > port needs to be created) instead?
It looks like newer versions of lua-nginx-module really want luajit and not lua. So it would probably require not just a different lua dependency but a different lua-nginx-module version depending on the arch. While it is _possible_ to do that, it makes it a real pain for handling updates, so unless someone has a strong need for the lua module on e.g. sparc64 it will be much simpler to disable lua-nginx-module unless an arch is supported by luajit.