On Thu, Jun 02, 2022 at 07:55:16AM +0100, Stuart Henderson wrote:
> On 2022/06/02 04:17, Yifei Zhan wrote:
> >  
> > +WebAssemble:
> > +
> > +- some websites require WebAssemble to be functional, this will appear in
> > +the JavaScript console as the following error:
> > +
> > +  Uncaught (in promise) ReferenceError: WebAssembly is not defined
> > +
> > +- WebAssemble is disabled by default due to stability issues, to enable it,
> > +exit chrome first if it's running then start chrome with ENABLE_WASM 
> > defined:
> > +
> > +  $ ENABLE_WASM=Yes chrome
> > +
> 
> it reads better with "it is disabled by default" first, followed by info on
> how to change it. some other tweaks including s/WebAssemble/WebAssembly/ :

is the "stability concerns" accurate ? I am running with it enabled since 
several long time without problems.

it has been disabled in 2019-04-17
  - disable wasm (WebAssembly) by default because it is a disaster

and ENABLE_WASM knob added in 2020-07-29
  - check if the ENABLE_WASM environment variable is set and do not disable
    webassembly if it is; this makes zoom.us (evil) work

so it is working in some extends since at least July, 2020.


anyway, I am fine with the proposed diff: it should be documented.
ok semarie@


> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/www/chromium/Makefile,v
> retrieving revision 1.637
> diff -u -p -r1.637 Makefile
> --- Makefile  28 May 2022 08:37:52 -0000      1.637
> +++ Makefile  2 Jun 2022 06:54:58 -0000
> @@ -7,7 +7,7 @@ DPB_PROPERTIES=               parallel parallel2
>  COMMENT=             Chromium browser
>  
>  V=                   102.0.5005.61
> -REVISION=            0
> +REVISION=            1
>  
>  DISTNAME=            chromium-${V}
>  
> Index: pkg/README
> ===================================================================
> RCS file: /cvs/ports/www/chromium/pkg/README,v
> retrieving revision 1.4
> diff -u -p -r1.4 README
> --- pkg/README        11 Mar 2022 20:09:41 -0000      1.4
> +++ pkg/README        2 Jun 2022 06:54:58 -0000
> @@ -37,6 +37,16 @@ webgl and 3d and acceleration support:
>  - some DRM supported cards are marked as unsupported by chromium
>  Using --ignore-gpu-blacklist may allow you to test
>  
> +WebAssembly:
> +- WebAssembly is disabled by default due to stability concerns, but some
> +websites will not function correctly without it - if this happens, the
> +JavaScript console will show the following error:
> +
> +    Uncaught (in promise) ReferenceError: WebAssembly is not defined
> +
> +To enable it, start chromium with ENABLE_WASM defined in the environment:
> +$ ENABLE_WASM=Yes chrome
> +
>  Interoperability with base window managers:
>  - some window managers do not have compositing support; for instance, fvwm.
>  In order to have decent graphic rendering, they should be supplemented by
> 

-- 
Sebastien Marie

Reply via email to