On 2022/05/20 07:43, Tracey Emery wrote:
> On Fri, May 20, 2022 at 08:21:44AM -0400, aisha wrote:
> > On 22/05/19 03:31PM, aisha wrote:
> > > Hi,
> > > Attached updated tarball with README containing an nginx configuration.
> > >
> > > Best,
> > > Aisha
> > >
> >
> > Added a section in README for setting up PHP cron jobs via crontab for www.
> >
>
> I think that is much better and gives someone else a place to start if
> they want to add other web servers. My only other question is the
> license: should it be AGPLv3+? I'll leave that to be answered by someone
> who understands any of that. Other than that, this reads OK to import to
> me. I'll trust as the maintainer you've tested it. :) Anyone have any
> opinions on that license?
I don't see an "or newer" so just AGPLv3 I think. Good catch though, that
is a *very* different license to GPL. With GPL, somebody just running the
software and not distributing it has nothing special to do. With AGPL someone
just running it and making services available on the network has to provide
source.
some comment from my previous review apply, about ${LOCALSTATEDIR} not
${VARBASE}
and ${LOCALBASE}/bin/${MODPHPSPEC}
