On Fri Mar 25, 2022 at 08:57:12PM +0100, Rafael Sadowski wrote:
> On Fri Mar 25, 2022 at 10:04:24AM +0100, Robert Nagy wrote:
> > Hi
> >
> > Our cmake has some hacks and due to that we cannot build binaries that
> > link to libraries with an OBJECT type because that means that all the object
> > files are pulled instead of linking to a static library. e.g.:
> >
> > Source/WTF/wtf/CMakeFiles/WTF.dir/./ApproximateTime.cpp.o
> >
> > But our cmake code modifies that to be -lApproximateTime.cpp.o which will
> > fail obviously.
> >
> > The following hack on top of our hack fixes the issue. aja@ is running a
> > bulk
> > wit this already:
>
> I work on a better, cleaner and documented cmComputeLinkInformation
> solution. If it pass a bulk, ok rsadowski. cmComputeLinkInformation
> cannot get any worse.
>
> Rafael
>
For the record, I am planning, or rather hoping, to delete the entire patch. I
don't think we need that anymore. I have already built and tested a lot of
ports without this patch. Libs and executables looks the same.
www/webkitgtk4 was the first port to fail but can simply fixed with:
index 34dd3c6c2ea..77a719a51cb 100644
--- a/www/webkitgtk4/Makefile
+++ b/www/webkitgtk4/Makefile
@@ -89,8 +89,8 @@ LIB_DEPENDS = archivers/woff2 \
CONFIGURE_ENV = WK_USE_CCACHE=NO
CONFIGURE_ARGS = -DPORT=GTK \
-DENABLE_MINIBROWSER=ON \
- -DCMAKE_EXE_LINKER_FLAGS="${LDFLAGS}" \
- -DCMAKE_SHARED_LINKER_FLAGS="${LDFLAGS}" \
+ -DCMAKE_EXE_LINKER_FLAGS="${LDFLAGS}
-L${LOCALBASE}/lib" \
+ -DCMAKE_SHARED_LINKER_FLAGS="${LDFLAGS}
-L${LOCALBASE}/lib" \
-DUSE_SYSTEMD=OFF \
-DUSE_SOUP2=ON
I would say this is nothing for 7.1.
