On Sun, Mar 20, 2022 at 10:52:35AM +0000, Stuart Henderson wrote:
> On 2022/03/20 10:51, Stuart Henderson wrote:
[...]
> > > devel/py-arrow
> > 
> > Drop MODPY_VERSION, NO_TEST
> > Set MODPY_PYTEST=Yes
> 
> Oh, and also drop devel/py-test TEST_DEPENDS, it is set by MODPY_PYTEST
> 
> > Use FLAVOR=python3 not FLAVOR?=python3
> > Beware this was previously in CVS, either use "cvs add" or be prepared to
> > merge conflicts, and take care of quirks
> > 
> > > devel/py-gevent-eventemitter
> > > graphics/py-pyqrcode
> > 
> > Same for FLAVOR?= -> FLAVOR=
> > s/0 tests/tests not included in pypi tarball/
> > 
> > > games/py-vdf
> > > games/py-vpk
> > > 
> > > Then games/py-steam, and finally games/steamctl.
> > 
> > I haven't looked at these

They also have FLAVOR ?= (except for steamctl which isn't a library or
module), so I fixed those, too.

Regarding sdk@'s comments:
> 
> games/py-vdf:
>   I think the "converters" category would be a better fit.
> 
> games/py-vpk:
>   Suggestion for COMMENT: tool and library for working with Valves Pak files
>   I think the "archivers" category would be a better fit.
> 
> graphics/py-pyqrcode:
>   DESCR: "The module can automates most of the building process"
>   Either drop the "can" or the "s" from automates.
> 
>   You're also referring to the optional pypng module in the Makefile and
>   DESCR. We don't have that module. Maybe keep the comment in the Makefile,
>   but drop it from DESCR to not send users on a hunt.

I incorporated all of the above recommendations into a new tarball,
attached again. I reworded DESCR for py-pyqrencode to drop the mention
of pypng.

With this, ok for import and the quirks fix for py-arrow? (see below)

> > Index: Makefile
> > ===================================================================
> > RCS file: /cvs/ports/devel/quirks/Makefile,v
> > retrieving revision 1.1365
> > diff -u -p -r1.1365 Makefile
> > --- Makefile        19 Mar 2022 10:36:05 -0000      1.1365
> > +++ Makefile        19 Mar 2022 20:58:50 -0000
> > @@ -3,7 +3,7 @@ CATEGORIES =        devel databases
> >  DISTFILES =
> >  
> >  # API.rev
> > -PKGNAME =  quirks-5.3
> > +PKGNAME =  quirks-5.4
> >  PKG_ARCH = *
> >  MAINTAINER =       Marc Espie <es...@openbsd.org>
> >  
> > Index: files/Quirks.pm
> > ===================================================================
> > RCS file: /cvs/ports/devel/quirks/files/Quirks.pm,v
> > retrieving revision 1.1379
> > diff -u -p -r1.1379 Quirks.pm
> > --- files/Quirks.pm 19 Mar 2022 10:36:05 -0000      1.1379
> > +++ files/Quirks.pm 19 Mar 2022 20:58:50 -0000
> > @@ -1102,8 +1102,6 @@ setup_obsolete_reason(
> >     3 => 'py-vatnumber',
> >     6 => 'nap',
> >     5 => 'qucs',
> > -   1 => 'py-arrow',
> > -   1 => 'py3-arrow',
> >     1 => 'py-chai',
> >     1 => 'py3-chai',
> >     1 => 'py-binaryornot',

Attachment: steamctl-plus-deps-rev0.tgz
Description: application/tar-gz

Reply via email to