On Fri Mar 18, 2022 at 01:22:43PM +0000, Stuart Henderson wrote:
> Remaining fallout:

Thanks Stuart for the report.

> 
> > graphics/openimageio
> 
> plist has
> lib/python${MODPY_VERSION}/site-packages/OpenImageIO.${MODPY_PYC_MAGIC_TAG}so.${LIBOpenImageIO_VERSION}
> 
> file produced is
> lib/python${MODPY_VERSION}/site-packages/OpenImageIO.${MODPY_PYC_MAGIC_TAG}so
> 
> - fix by regen plist + bump?

Absolutely, OpenImageIO.${MODPY_PYC_MAGIC_TAG}so with verison feels wrong.

> 
> > audio/mumble
> 
> plist has lib/mumble/libcelt0.so.0.7.0
> file produced is now lib/mumble/libcelt0.so.0.0
> 
> - fix with "SHARED_LIBS += celt0 X.X" + regen plist + bump?
> (seems a good idea to have the version number 'higher' than the
> existing one and not the same as the real /usr/local/lib/libcelt0
> so I'd probably go with 1.0 if it works)

Fixed by kn@ Thanks

> 
> > geo/mdal
> 
> The patch to mdal removes too much as it stops trying to use -lsqlite3
> to link.
> 
> [99/119] : && /pobj/mdal-0.9.4/bin/c++ -O2 -pipe   -I/usr/local/include 
> -DNDEBUG  tools/CMakeFiles/mdal_translate.dir/mdal_translate.cpp.o -o 
> tools/mdal_translate -L/pobj/mdal-0.9.4/build-i386/mdal   -L/usr/local/lib   
> -L/usr/lib -Wl,-z,origin,-rpath,/pobj/mdal-0.9.4/build-i386/mdal:  -lmdal  
> -lhdf5  -lz  -lm  -lgdal  -lnetcdf  -lxml2  
> -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib && :
> FAILED: tools/mdal_translate 
> : && /pobj/mdal-0.9.4/bin/c++ -O2 -pipe   -I/usr/local/include -DNDEBUG  
> tools/CMakeFiles/mdal_translate.dir/mdal_translate.cpp.o -o 
> tools/mdal_translate -L/pobj/mdal-0.9.4/build-i386/mdal   -L/usr/local/lib   
> -L/usr/lib -Wl,-z,origin,-rpath,/pobj/mdal-0.9.4/build-i386/mdal:  -lmdal  
> -lhdf5  -lz  -lm  -lgdal  -lnetcdf  -lxml2  
> -Wl,-rpath-link,/usr/X11R6/lib:/usr/local/lib && :
> ld: error: /pobj/mdal-0.9.4/build-i386/mdal/libmdal.so: undefined reference 
> to sqlite3_close [--no-allow-shlib-undefined]
> ld: error: /pobj/mdal-0.9.4/build-i386/mdal/libmdal.so: undefined reference 
> to sqlite3_open [--no-allow-shlib-undefined]
> ld: error: /pobj/mdal-0.9.4/build-i386/mdal/libmdal.so: undefined reference 
> to sqlite3_finalize [--no-allow-shlib-undefined]
> ld: error: /pobj/mdal-0.9.4/build-i386/mdal/libmdal.so: undefined reference 
> to sqlite3_prepare_v2 [--no-allow-shlib-undefined]
> ld: error: /pobj/mdal-0.9.4/build-i386/mdal/libmdal.so: undefined reference 
> to sqlite3_step [--no-allow-shlib-undefined]
> ld: error: /pobj/mdal-0.9.4/build-i386/mdal/libmdal.so: undefined reference 
> to sqlite3_column_int [--no-allow-shlib-undefined]
> ld: error: /pobj/mdal-0.9.4/build-i386/mdal/libmdal.so: undefined reference 
> to sqlite3_column_count [--no-allow-shlib-undefined]
> c++: error: linker command failed with exit code 1 (use -v to see invocation)
> 

I guess my mind wasn't really on the job. Built clean if we do nothing.

If there are no further concerns, I would be happy to commit this.

Reply via email to