Hi Stefan --

On 3/13/2022 7:49 AM, Stefan Hagen wrote:
> Hi,
> 
> cat DESCR
> Twmn is a dmenu style desktop notification system.
> 
> Notifications are shown in a one-line bar called the notification slide.
> They can be navigated through and activated with shortcuts.
> 
> * twmnc: is a command line tool to send notifications to twmnd.
> * twmnd: is a daemon listening to notification requests and showing them
> one after another. It is also compatible with "notify-send".
> 
> Tested on amd64. An example config can be found in the README.md in the 
> examples dir.
> 
> OK? Comments?
> 
> Best Regards,
> Stefan

Only lightly tested and seems to work OK.
Some thoughts:

Your distinfo is incomplete:
SHA256 (-58ca77dd.tar.gz) = WNLEjHKQVRgjINQeG889W0T9NayCyVgh0Mj8tjZvthc=

Fixed here by re-running `make makesum`:
SHA256 (twmn-0.0.0.1-58ca77dd.tar.gz) =
WNLEjHKQVRgjINQeG889W0T9NayCyVgh0Mj8tjZvthc=

You put GPLv3+ as the license but the repo LICENSE is a copy of the
LGPLv3. I don't see anywhere that says you can use LGPLv3+, so I think
the license marker should be LGPLv3 only.

NO_TEST = Yes is probably needed:
===>  Regression tests for twmn-0.0.0.1
make: don't know how to make test
Stop in
/usr/ports/pobj/twmn-0.0.0.1/twmn-58ca77dde5a007ef0edb7c6e2312310adaf68c7d/build-amd64

There are -Werror flags building twmnd, those should go.

Other than that, works ok, so ok with these fixes.

~Brian

Reply via email to