On Wed, Mar 02, 2022 at 11:10:11AM +0100, Marc Espie wrote: > On Tue, Mar 01, 2022 at 09:46:19PM -0500, Josh Grosse wrote: > > On Tue, Mar 01, 2022 at 05:42:32PM +0100, Marc Espie wrote: > > > > > > Here's an update to gmic and gmic-qt. > > > This uses the newly commited framework parts that ditch $OpenBSD$ > > > Hence a bit of churn. > > > > > > Apart from that, things seem okay. > > > > > > There was a fuck-up wrt the cmake framework with upstream, taken care of > > > with (merged) pr264, so that part of the patch should go away when the > > > next > > > minor release comes out. > > > > > > Tested lightly with the gmic demos and the gimp filters. > > > > Tested gmic, gmic-qt-none, and gmic-qt-gimp successfully. > > > > I am unable to successfully test gmic-qt-krita. AFAIK, krita 5.0.0 > > integrated > > gmic, and we are at krita 5.0.2. I'm not a krita user, so my inability to > > find gmic filters within may just be my limited understanding of how to > > use krita. Or, it could be that gmic-qt-krita is no longer needed. > > I'll check krita, but from what I see in the tarball, it doesn't seem the > integration goes beyond fetching gmic (which will break for us, obviously) > and building and installing a vaguely patched version (mostly having to > do with auto-updating gmic) > > Okay, they actually did some puky thing with gmic, I have zero idea why they thought bundling & forking was a good idea.
Looks I can grab their patch, which defines a new kritaplugin type, and integrate it in gmic... I have zero idea why they wouldn't work with the gmic people and do things on their own that way. Anyhow, this means I can commit, because the current krita host no longer works anyhow. neither rsadowski@ nor sdk@ noticed, but they quietly broke this when they switched to krita 5.0.