On Mon, Feb 28, 2022 at 10:12:38PM +0000, Stuart Henderson wrote: > On 2022/02/28 19:02, Marc Espie wrote: > > This kills both the generation and copying of $OpenBSD$ lines in > > update-patches. > > > > Main question is: are we okay generatin patches starting with Index: or > > do we want to leave an empty line (or something) reminding people to add > > an actual comment > > > > (that's the first chunk of the patch) > > I think it's fine like that, but it could have some handling for > an empty second line in existing patches, as-is it keeps them, > so after a while we'll have a mixture of some files with an > empty first line and others with the comment or patch on the > first line. > > Diff on top is not the prettiest but seems to do the trick.
Oh, it's probably simpler to post-process the comment list before returning. Then there's no need to keep state. (It worked for just one line being simple enough) I'll have a look tomorrow unless you beat me to it.
