On 2022/02/12 11:21, Klemens Nanni wrote:
> On Fri, Feb 11, 2022 at 09:40:12PM -0700, Kurt Mosiejczuk wrote:
> > http://build-failures.rhaalovely.net/sparc64/2022-02-09/news/nzbget.log
> 
> > /tmp/PostScript-e00a4a.s:3155: Error: operation combines symbols in 
> > different segments
> > clang-13: error: assembler command failed with exit code 1 (use -v to see 
> > invocation)
> 
> ports-gcc fixes this.  Bump to sure in case this changes the compiler on
> an arch where ports-clang worked.

ok

> While here, substitute the config just once in post-patch. pre-configure
> would needlessly be rerun on every `make clean=build && make build'.

This breaks the familiar "make patch; edit $somefile; make
update-patches" workflow and you have to fiddle with pre-subst
files instead. Or more likely, try to edit $somefile, run
update-patches, notice that it didn't pick up the changes,
then recreate them in pre-subst. So I don't like that part.

> OK?
> 
> Index: Makefile
> ===================================================================
> RCS file: /home/cvs/ports/news/nzbget/Makefile,v
> retrieving revision 1.5
> diff -u -p -r1.5 Makefile
> --- Makefile  4 Jun 2021 03:18:47 -0000       1.5
> +++ Makefile  12 Feb 2022 11:08:36 -0000
> @@ -3,6 +3,7 @@
>  COMMENT =    binary newsreader supporting NZB files
>  
>  VERSION =    21.1
> +REVISION =   0
>  DISTNAME =   nzbget-${VERSION}
>  
>  CATEGORIES = news
> @@ -20,7 +21,7 @@ MASTER_SITES =      https://github.com/nzbget
>  EXTRACT_SUFX =       -src.tar.gz
>  
>  # C++14
> -COMPILER =   base-clang ports-clang ports-gcc
> +COMPILER =   base-clang ports-gcc
>  
>  RUN_DEPENDS =        archivers/p7zip \
>               archivers/unrar
> @@ -38,7 +39,7 @@ CONFIGURE_ARGS =    --with-libcurses-includ
>  
>  NO_TEST =    Yes
>  
> -pre-configure:
> +post-patch:
>       ${SUBST_CMD} ${WRKSRC}/nzbget.conf
>  
>  .include <bsd.port.mk>
> 

Reply via email to