On Sat, February 5, 2022 18:32, Bjorn Ketelaars wrote: > Diff below updates miniupnpd to 2.3.0. Noticeable change is that > miniupnpd now uses pledge() (introduced in 2.2.0). Full changelog can be > found at [0]. > > Diff is big as we can drop almost all patches, issues have been > addressed upstream. > > So far it works for me on amd64. > > OK?
Hi, Iwas updating it to 2.2.2 and forgot to send a patch :) Some comments below. > > [0] https://github.com/miniupnp/miniupnp/blob/master/miniupnpd/Changelog.txt. > > > diff --git Makefile Makefile > index 1c048358808..0bd731936d8 100755 > --- Makefile > +++ Makefile > @@ -2,18 +2,17 @@ > > COMMENT= UPnP IGD daemon > > -DISTNAME= miniupnpd-2.1 > -REVISION= 2 > +DISTNAME= miniupnpd-2.3.0 > > +# uses pledge() > WANTLIB += c crypto kvm ssl > > -MAKE_FLAGS= INSTALLETCDIR=${PREFIX}/share/examples/miniupnpd \ > - INSTALLMANDIR=${PREFIX}/man/man8 > +MAKE_FLAGS= INSTALLETCDIR=${PREFIX}/share/examples/miniupnpd > > FAKE_FLAGS= PREFIX=${TRUEPREFIX} > > CONFIGURE_STYLE= simple > -CONFIGURE_SCRIPT= genconfig.sh > +CONFIGURE_SCRIPT= configure No need for CONFIGURE_SCRIPT. configure - is the default. > > post-install: > ${INSTALL_MAN_DIR} ${PREFIX}/man/man8 The line above could be dropped. I suggest to add it to CVE list in quirks https://repology.org/project/miniupnpd/cves?version=2.0.20171212 Slightly tested with upnpc. OK kirby@ > diff --git distinfo distinfo > index a4312372784..dd69bfa3e4d 100644 [...]