On Wed, Jan 19, 2022 at 02:07:20PM +0100, Theo Buehler wrote:
> On Wed, Jan 19, 2022 at 01:00:24PM +0000, Klemens Nanni wrote:
> > On Wed, Jan 19, 2022 at 12:51:31PM +0100, Henrik Friedrichsen wrote:
> > > On Wed, Jan 19, 2022 at 11:19:48AM +0000, Klemens Nanni wrote:
> > > > It fails to build on amd64 for me:
> > > > error: there is no argument named `content_len`
> > > > --> src/ui/listview.rs:88:34
> > > > |
> > > > 88 | log::info!("content len: {content_len}");
> > > > | ^^^^^^^^^^^^^
> > > >
> > > > error: there is no argument named `loaded`
> > > > --> src/ui/listview.rs:100:35
> > > > |
> > > > 100 | log::info!("can paginate: {loaded}");
> > > > | ^^^^^^^^
> > > >
> > >
> > > Yes, it needs rust-1.58.0 to build.
> >
> > Thanks, that works.
> >
> > Is this expected?
>
> Yes. It's using captured identifiers, a feature that stabilized with 1.58.
>
> > Does that concern ncspot alone or other rust ports as well?
>
> This is part of the ncspot source. Other ports will likely start using
> this feature. Unless you backport to stable this shouldn't be a concern.
> rust's short support cycle makes backports to stable hard anyway.
Thanks for the insights.
> > Do we just expect (package bulk) machines to always build with the
> > latest version or does that warrant some kind of version pinning for
> > lang/rust?
>
> Yes, a bulk build will build the latest rust in tree and use it.
Yes, that I know, just wanted to know if this is considered good enough.
> I see no reason for pinning.
I guess it is, but figured asking doesn't hurt.
I'll commit the ncspot update, thanks Henrik!
