On 2022/01/11 13:39, Jeremie Courreges-Anglas wrote:
> > If the alignment problem on armv7 still exists then it may need this
> >
> > COMPILER =  ports-gcc base-clang
> > MODGCC4_ARCHS =     armv7
> 
> This would restrict the use of ports-gcc to armv7, maybe fixing
> the alignement problem on armv7 but not addressing the recent C++
> compiler requirement on sparc64 and other non-clang archs.

Ah right, it would need to list the other members of GCC49_ARCHS that aren't
also CLANG_ARCHS, which is annoying so let's hope it is no longer needed :)

> > (MODGCC4_ARCHS is not really outdated, it is the way we can restrict
> > ports-gcc so that it's only used on specific archs. It's not needed
> > very often though).
> 
> The variable MODGCC4_ARCHS is not outdated indeed, but its use in this
> Makefile lead me to think that its addition predated armv7 switching to
> clang.  Turns out this was not true.

Ah, I suppose it was a noop change then, oops.

> I'll try to test mupdf on armv7 when I get some time, in the meantime
> I'll commit this diff which should strictly improve the situation.

ack

Reply via email to