Omar Polo <o...@openbsd.org> writes: > Gabriel Hondet <gabriel.hon...@laposte.net> writes: > >> Hi! >> >> I have updated the Makefile of xbindkeys >> (https://www.nongnu.org/xbindkeys/xbindkeys.html). >> >> xbindkeys is a window manager agnostic key binding utility. It reads >> a configuration file (either a Guile scheme file or an ad-hoc syntax) >> to bind keys to actions. >> >> Previously, xbindkeys was systematically built with the `--disable-guile` >> option and thus would not read guile scheme files. This update >> removes the flag and adds a flavour "noguile" that uses it. >> >> Of course, I'd be happy to fix any issue on my contribution, >> cheers, >> Gabriel > > Hello :) > > Please send (unified) diffs for ports updates/tweaking. If you checked > out the port tree using cvs, just run `cvs diff > /tmp/xbindkeys.diff` > in the port directory and attach that file, otherwise you can also use > git/got to clone from the github mirror https://github.com/openbsd/ports > > Anyway, I'd do the opposite regarding the flavor: add a -guile flavor to > enable guile support. `no_*' flavors are treated especially (see > bsd.port.mk(5)) and for what I can see flavors usually add stuff (see > mail/mutt for instance). > > Thanks, > > Omar Polo
On a second thought, we might just enable guile in the port without adding another flavor. (only build tested) Index: Makefile =================================================================== RCS file: /home/cvs/ports/x11/xbindkeys/Makefile,v retrieving revision 1.24 diff -u -p -r1.24 Makefile --- Makefile 21 Nov 2020 12:32:55 -0000 1.24 +++ Makefile 19 Dec 2021 23:53:25 -0000 @@ -2,6 +2,7 @@ COMMENT = bind keys or mouse buttons to shell commands under X11 DISTNAME = xbindkeys-1.8.7 +REVISION = 0 CATEGORIES = x11 HOMEPAGE = https://www.nongnu.org/xbindkeys/xbindkeys.html @@ -9,19 +10,19 @@ HOMEPAGE = https://www.nongnu.org/xbindk # GPLv2+ PERMIT_PACKAGE = Yes -WANTLIB = X11 c +WANTLIB = X11 c gc guile-2.2 pthread # not on MASTER_SITE_SAVANNAH MASTER_SITES = ${HOMEPAGE:=/../} MODULES = x11/tk +LIB_DEPENDS = lang/guile2 RUN_DEPENDS = ${MODTK_RUN_DEPENDS} \ devel/desktop-file-utils SEPARATE_BUILD = Yes CONFIGURE_STYLE = gnu -CONFIGURE_ARGS += --disable-guile NO_TEST = Yes
