Brad Smith wrote: > ping. > On 11/7/2021 1:24 AM, Brad Smith wrote: > > Here is an update to OpenImageIO 2.2.19.0. > > > > The ustring.cpp and sysutil.cpp diffs (plus some more) I had merged > > upstream. The rest do not appear to be necessary. TBB was removed > > in 2014. > > > > > > Release 2.2.19 (1 Nov 2021) -- compared to 2.2.18 > > -------------------------------------------------- > > * Better catching of exceptions thrown by OCIO 1.x if it encounters 2.0 > > config > > files. #3089 > > * Address new warnings revealed by clang 13. #3122 > > * Fixed some minor python binding bugs. #3074 #3094 > > * Fix when building with Clang on big-endian architectures. #3133 > > * Fix occasional build breaks related to OpenCV headers. #3135 > > * Improvements to NetBSD and OpenBSD support. #3137. > > * Fixes to work with the libraw 202110 snapshot. #3143
I was looking into openimageio already in the last days. Cool that all the patches got upstreamed. I also see that only 9 instead of 16 tests are failing compared to the previous version (on amd64). It looks worse on sparc64 (same as in previous version): 32% tests passed, 63 tests failed out of 92 $ make lib-depends-check openimageio-2.2.19.0(graphics/openimageio): Extra: iconv.7 There're one more issue, which was also present in the previous version. These lines caught my eye: [246/248] cd /home/dpb/usr/ports/pobj/openimageio-2.2.19.0/build-amd64/src/doc && /home/dpb/usr/ports/pobj/openimageio-2.2.19.0/build-amd64/bin/oiiotool --help | /usr/local/bin/python3.9 /home/dpb/usr/ports/pobj/openimageio-2.2.19.0/oiio-Release-2.2.19.0/src/doc/help2man_preformat.py | /usr/local/bin/txt2man -v OpenImageIO -s 1 -t oiiotool > /home/dpb/usr/ports/pobj/openimageio-2.2.19.0/build-amd64/src/doc/oiiotool.1 gawk: cmd. line:58: warning: regexp escape sequence `\o' is not a known regexp operator gawk: cmd. line:116: warning: regexp escape sequence `\,' is not a known regexp operator gawk: cmd. line:116: warning: regexp escape sequence `\;' is not a known regexp operator gawk: cmd. line:145: (FILENAME=- FNR=10) fatal: invalid regexp: Unmatched ( or \(: /\<(one\>/ What this is trying to do is to convert the help output of the individual tools into their respective manpages. This is more or less successful. For idiff it works. The other manpages have a stray %* in the first section. The oiiotool manpage is completely broken. Fixing this would be nice, but I think we could also just omit the manpage installation. They provide no added value over the --help output. And in this case "no manpage" might be better than a broken one. Overall it's an improvement over the last version, therefore OK sdk@ wich iconv removed from WANTLIB. It takes a long time to compile on sparc64 and it's there only as a dependency for blender, which doesn't build on sparc64. Is there a reason to *not* mark it as broken for sparc64? 32% test passed is closer to broken than to working. So my suggestion would be to mark it as broken on sparc64 with a comment until it's needed as dependency by something. Other opinions? OK? Best Regards, Stefan
