On Tue, Dec 07, 2021 at 10:34:59PM +0000, Stuart Henderson wrote: > On 2021/12/07 23:11, Solene Rapenne wrote: > > Cozy is a modern GTK audiobook player, it requires a freshly committed > > databases/py-peewee update to run. It compiles in a clean chroot, > > > > tested for hours without issues > > > > pkg/DESCR > > > > Here are some of the current features: > > - Import your audiobooks into Cozy to browse them comfortably > > - Sort your audio books by author, reader & name > > - Remembers your playback position > > - Sleep timer > > - Playback speed control > > - Search your library > > - Drag & Drop to import new audio books > > : BUILD_DEPENDS = audio/py-mutagen${MODPY_FLAVOR} \ > : databases/py-peewee${MODPY_FLAVOR} \ > : devel/gettext,-tools \ > : devel/py-gobject3${MODPY_FLAVOR} \ > : sysutils/py-distro${MODPY_FLAVOR} \ > : x11/elementary/granite \ > : x11/libhandy > : > : RUN_DEPENDS = audio/py-mutagen${MODPY_FLAVOR} \ > : databases/py-peewee${MODPY_FLAVOR} \ > : devel/desktop-file-utils \ > : devel/py-gobject3${MODPY_FLAVOR} \ > : multimedia/gstreamer1/plugins-libav \ > : sysutils/py-distro${MODPY_FLAVOR} \ > : x11/elementary/granite \ > : x11/gnome/libdazzle \ > : x11/gtk+3,-guic \ > : x11/libhandy > > OK, either as-is, or with the change below - it's often easier for > updates (and readability) to factor out the common deps, like this
As long as you don't do `RUN_DEPENDS = ${BUILD_DEPENDS} ...' which looks cleverer than it is. Pretty sure I did this myself at some point... until an update comes around and you change the explicit dependency while neglecting the implicit one. You folks surely know this; I'm putting this out here for the archives. > COMMON_DEPENDS = audio/py-mutagen${MODPY_FLAVOR} \ > databases/py-peewee${MODPY_FLAVOR} \ > devel/py-gobject3${MODPY_FLAVOR} \ > sysutils/py-distro${MODPY_FLAVOR} \ > x11/elementary/granite \ > x11/libhandy > > BUILD_DEPENDS = ${COMMON_DEPENDS} \ > devel/gettext,-tools > > RUN_DEPENDS = ${COMMON_DEPENDS} \ > devel/desktop-file-utils \ > multimedia/gstreamer1/plugins-libav \ > x11/gnome/libdazzle \ > x11/gtk+3,-guic >