Hi Stefan, On Sun, Dec 05, 2021 at 01:59:03PM +0100, Stefan Hagen wrote: > Sergey A. Osokin wrote: > > could you please review and commit the attached patch to update > > NGINX Unit to its recent bugfix release - 1.26.1. > > > > Here's the commit message: > > > > -------- > > www/unit: update from 1.26.0 to 1.26.1. > > > > <ChangeLog> > > > > *) Bugfix: occasionally, the Unit daemon was unable to fully terminate; > > the bug had appeared in 1.26.0. > > > > *) Bugfix: a prototype process could crash on an application process > > exit; the bug had appeared in 1.26.0. > > > > *) Bugfix: the router process crashed on reconfiguration if "access_log" > > was configured without listeners. > > > > *) Bugfix: a segmentation fault occurred in the PHP module if chdir() or > > fastcgi_finish_request() was called in the OPcache preloading script. > > > > *) Bugfix: fatal errors on DragonFly BSD; the bug had appeared in > > 1.26.0. > > > > </ChangeLog> > > -------- > > > > Thank you. > > It looks like unit-php is not built. But this is not new in this > version. Therefore ok sdk@ for this diff, but unit-php should be looked > at.
Unit's PHP module needs a PHP shared library, i.e. embedded feature,
otherwise it fails. sthen's recommendation was to do some improvements
in php ports.
> When php is not installed, unit-php does not pull it in, because php is
> only in RUN_DEPENDS.
>
> sthen already added MODPHP_BUILDDEP=Yes and I thought adding
> BUILD_DEPENDS=lang/php/${MODPHP_VERSION},-embed
> would fix the port. But it doesn't.
>
> $ make
> ===> unit-php74-1.26.1 depends on: php-embed-<7.5 - not found
> ===> Verifying install for php-embed-<7.5 in lang/php/7.4
> ===> Returning to build of unit-php74-1.26.1
> ===> unit-php74-1.26.1 depends on: php-embed-<7.5 - not found
> Dependency check failed
> *** Error 1 in . (/home/dpb/usr/ports/infrastructure/mk/bsd.port.mk:2276
> '/home/dpb/usr/ports/pobj/unit-php74-1.26.1-php74/.dep-lang-php-7.4,-embed')
> *** Error 2 in /usr/ports/www/unit/unit-php
> (/home/dpb/usr/ports/infrastructure/mk/bsd.port.mk:2594 'all':
> @lock=unit-php74-1.26.1; export ...)
>
> I have FETCH_PACKAGES set and it should have fetched "php-embed-7.4.26p2"
> or build it.
--
Sergey Osokin
signature.asc
Description: PGP signature
