On 2021/11/24 21:39, Kinichiro Inoguchi wrote:
> On Wed, Nov 24, 2021 at 08:45:36AM +0000, Stuart Henderson wrote:
> > On 2021/11/23 17:33, Kinichiro Inoguchi wrote:
> > > This adds perl and ruby bindings to libmarisa as sub packages.
> > > Currently only python binding is included.
> > > I had checked this with sample.pl and sample.rb on my openbsd7.0/amd64,
> > > and saw this works fine.
> > >
> > > Incremented REVISION-main and added REVISION-python in Makefile.
> > >
> > > ok?
> >
> > There are some surplus WANTLIB:
> >
> > $ make port-lib-depends-check
> >
> > p5-libmarisa-0.2.6(textproc/libmarisa,-perl):
> > Extra: c++.8 c++abi.5 pthread.26
> >
> > py3-libmarisa-0.2.6p0(textproc/libmarisa,-python):
> > Extra: python3.9.0
> >
> > ruby-libmarisa-0.2.6(textproc/libmarisa,-ruby):
> > Extra: gmp.11 ruby30.0
> >
> >
> > Removing those WANTLIB will invalidate the LIB_DEPENDS entries (there needs
> > to
> > be an associated WANTLIB), so those will need to change to RUN_DEPENDS.
> >
>
> Thanks for pointing out this.
> I had checked all WANTLIB and LIB_DEPENDS again and now I saw
> 'make port-lib-depends-check' finished successfully.
> I did not add RUN_DEPENDS for this since LIB_DEPENDS is enough.
> ok?
There are RUN_DEPENDS for both Python and Ruby in all subpackages:
$ make dump-vars|grep RUN_DEPENDS
textproc/libmarisa,-main.RUN_DEPENDS=lang/python/3.9 lang/ruby/3.0
textproc/libmarisa,-perl.RUN_DEPENDS=lang/python/3.9 lang/ruby/3.0
textproc/libmarisa,-python.RUN_DEPENDS=lang/python/3.9 lang/ruby/3.0
textproc/libmarisa,-ruby.RUN_DEPENDS=lang/python/3.9 lang/ruby/3.0
So you need:
RUN_DEPENDS-main= # empty
RUN_DEPENDS-perl= # empty
RUN_DEPENDS-python= ${MODPY_RUN_DEPENDS}
RUN_DEPENDS-ruby= ${MODRUBY_RUN_DEPENDS}
Also running "make plist" adds new files to PLIST-perl:
--- pkg/PLIST-perl Wed Nov 24 14:13:37 2021
+++ pkg/PLIST-perl.new Wed Nov 24 14:27:36 2021
@@ -3,4 +3,6 @@ ${P5ARCH}/
${P5ARCH}/auto/
${P5ARCH}/auto/marisa/
@so ${P5ARCH}/auto/marisa/marisa.so
+${P5ARCH}/benchmark.pl
${P5ARCH}/marisa.pm
+${P5ARCH}/sample.pl
I agree with removing them, but it should be explicit so they don't
get added back in by mistake later. Either add to PLIST with @comment:
@so ${P5ARCH}/auto/marisa/marisa.so
@comment ${P5ARCH}/benchmark.pl
${P5ARCH}/marisa.pm
@comment ${P5ARCH}/sample.pl
or rm in post-install.
