On 2021/11/19 21:44, Brad Smith wrote: > On 10/21/2021 4:28 PM, Stuart Henderson wrote: > > > On 2021/10/02 04:42, Brad Smith wrote: > > > Attached is a port of libcrossguid. > > > > > > Comment: > > > minimal and cross platform C++ GUID library > > > > > > Description: > > > CrossGuid is a minimal, cross platform, C++ GUID library. It uses the > > > best native GUID/UUID generator on the given platform and had a generic > > > class for parsing, stringifying, and comparing IDs. > > No idea why "make package" didn't moan about it but it has LIB_DEPENDS > > without an associated WANTLIB. > > > > How about this instead though, using uuid functions from libc instead, > > and enabling tests. OK with me. > > This doesn't seem to work at all for me. I see it's not taking the > elseif(OPENBSD) > path but instead falling back to finding libuuid. > > And this part.. > > target_compile_definitions(crossguid GUID_OPENBSD) > > Looks like it should be.. > > target_compile_definitions(crossguid PRIVATE GUID_OPENBSD) > > and I don't see a patch for src/guid.cpp. >
Weird. Not sure what machine that was on, can't find it in any of my trees at the moment (I have moved some stuff around after I had to switch to a different machine as my main workstation, too many kernel hangs when it was running X) IIRC it needed to not be private as it changed something in the header. The attachment was missing from your other mail, I'll have a look at redoing it, it seems silly to have a library that's meant to use a native uuid implementation not use the available native implementation.
