On Wed, Nov 03, 2021 at 02:30:46PM +0000, Stuart Henderson wrote:
> On 2021/11/03 15:04, Marc Espie wrote:
> > On Wed, Nov 03, 2021 at 01:04:38PM +0000, Stuart Henderson wrote:
> > > On 2021/11/03 12:55, Ricardo Mestre wrote:
> > > > Hi,
> > > > 
> > > > And now with diff attached, files retrieved from maintainer's gh 
> > > > repository.
> > > > 
> > > > Still works on amd64, OK?
> > > 
> > > $ make show=PKGNAMES
> > > lha-1.14i-ac20210926
> > > 
> > > this is invalid, the ac20210926 is in the part of the name that is 
> > > reserved for flavours
> > > 
> > > 
> > I've added tools to the ports tree to check for that, actually.
> > hub$ /usr/ports/infrastructure/bin/pkg_check-version -H lha-1.14i-ac20210926
> > lha-1.14i-ac20210926:
> >         stem: lha
> >         version (split): 1 14i
> >         no suffix
> >         no REVISION
> >         no EPOCH
> >         flavors: ac20210926
> > 
> > works wonders in case you have any doubt ;)
> > 
> 
> if you remember to run it. But since people keep sending things with
> "XXX not needed for" in pkg_create which is printed by default I don't
> have much hope for anything needing extra steps ..
> 
> 
As a rule, if an existing port has distinct PKGNAME/DISTNAME, you should
always verify your names.

Maybe I should add a "MAINTAINER" thingy that runs extra checks by default ?...

Reply via email to