On Mon 11/10/2021 09:15, Rafael Sadowski wrote: > On Fri Oct 08, 2021 at 06:31:58AM +0200, Bjorn Ketelaars wrote: > > On Thu 07/10/2021 21:48, Rafael Sadowski wrote: > > > First cmake update victim, reported by Mark Patruck, Thanks! Please find > > > below a minizip update diff. > > > > > > - Switch from nmoinvaz/minizip (dead) to zlib-ng/minizip-ng. > > > - Enable LZMA support > > > > > > Build test with the following consumer: > > > > > > - emulators/mupen64plus/core > > > - geo/spatialite/libspatialite > > > - net/wireshark > > > - geo/spatialite/librasterlite2 > > > > > > OK? > > > > I have multiple tests failing on me, which is not the case for > > minizip-2.10.1. test.log enclosed. > > You compare 140 (old) vs 288 (new) test cases. Those who fail under the > new version do not exist in the old one.
Yes, you are right. I did not give much attention to the difference in number of tests. Sorry if that caused noise. I am not ruling out that I'm not doing something stupid. At least I'm able to reproduce the failing tests from 3.0.3 in a chroot. From minizip's test log it seems that there are two types of errors, see below. No clue about the root cause. Error -117 (Signing error), e.g. 207/288 Testing: raw-unzip-signed 207/288 Test: raw-unzip-signed Command: "/usr/ports/pobj/minizip-3.0.3/build-amd64/minizip" "-x" "-o" "-h" "test.p12" "-w" "test" "-d" "out" "result.zip" Directory: /usr/ports/pobj/minizip-3.0.3/minizip-ng-3.0.3/test "raw-unzip-signed" start time: Oct 11 17:59 CEST Output: ---------------------------------------------------------- minizip-ng 3.0.3 - https://github.com/zlib-ng/minizip-ng --------------------------------------------------- -x -o -h test.p12 -w test -d out result.zip Archive result.zip Extracting test.c Error -117 saving entries to disk result.zip <end of output> Test time = 0.04 sec ---------------------------------------------------------- Test Failed. "raw-unzip-signed" end time: Oct 11 17:59 CEST "raw-unzip-signed" time elapsed: 00:00:00 ---------------------------------------------------------- Error -117/-105 (Signing error / CRC error), e.g. 228/288 Testing: lzma-unzip-signed 228/288 Test: lzma-unzip-signed Command: "/usr/ports/pobj/minizip-3.0.3/build-amd64/minizip" "-x" "-o" "-h" "test.p12" "-w" "test" "-d" "out" "result.zip" Directory: /usr/ports/pobj/minizip-3.0.3/minizip-ng-3.0.3/test "lzma-unzip-signed" start time: Oct 11 17:59 CEST Output: ---------------------------------------------------------- minizip-ng 3.0.3 - https://github.com/zlib-ng/minizip-ng --------------------------------------------------- -x -o -h test.p12 -w test -d out result.zip Archive result.zip Extracting test.c Error -117 saving entries to disk result.zip Error -105 closing archive for reading <end of output> Test time = 0.04 sec ---------------------------------------------------------- Test Failed. "lzma-unzip-signed" end time: Oct 11 17:59 CEST "lzma-unzip-signed" time elapsed: 00:00:00 ----------------------------------------------------------
