Dimitri Karamazov wrote: > On Tue, Aug 31, 2021 at 12:41:44PM +0200, Stefan Hagen wrote: > > Dimitri Karamazov wrote: > > > On Thu, Aug 26, 2021 at 05:03:52PM +0000, Dimitri Karamazov wrote: > > > > Simple update for www/qutebrowser to 2.3.1 > > > > > > > > Changelog:https://www.qutebrowser.org/doc/changelog.html > > > > > > > > Build & Run tested on amd64 > > > > Same here. Builds and runs and passes the usual checks on amd64. > > > > Have you ever attempted to make the test suite run? It fails currently. > > > > The test suite sais tox should be used. But also with tox, it fails > > to run, but differently. > > > > Besides that, LGTM. > > > > Best regards, > > Stefan > > The tests do run well as a normal user and they are interactive > with no way to exit. They fail if you try to run as _pbuild. > > Try `python3.8 ./setup.py test` as a normal user with X11 running. > > TEST_IS_INTERACTIVE = X11 might be the more sensible change. > > I might attempt to make it work using tox next week. > > regards, > Dimitri
I don't think the test suite should block this update from going in. The update to tox can be done at a later time as well. With added # does not run under _pbuild TEST_IS_INTERACTIVE = X11 OK sdk@
