Solene Rapenne <sol...@perso.pw> writes:
> On Thu, 16 Sep 2021 09:04:37 +0200
> Omar Polo <o...@omarpolo.com>:
>
>> Solene Rapenne <sol...@perso.pw> writes:
>>
>> > Import a simple python dependency for editors/apostrophe
>> >
>> > I generated it with portgen, checked version, DESCR, PLIST, licensing.
>> > I didn't add pandoc as a dependency because it's not required to
>> > have it at build stage, and I'm not sure it would be fine to add
>> > pandoc as a run dep either.
>>
>> without text/pandoc as TEST_DEPENDS the tests fails; well, they fails
>> nevertheless because it tries to fetch stuff from github. No idea how
>> to fix it, sorry.
>>
>> Anyway, I'd argue that it needs text/pandoc as {RUN,TEST}_DEPENDS and
>> not RDEP on it from apostrophe since it searches for the binary and
>> throw an error if not found. Attaching another tarball with pandoc
>> added as deps.
>>
>> Cheers,
>>
>
> I added TEST_DEPENDS , it can make 23 checks before failing
> when trying to download its own sources to use the README.md file...
> but I suppose 23 checks working is better than nothing.
I was distracted by the error output and the /writes_to_HOME lines. It
seems that all but that test are succeeding, which is good I guess.
> It's now depending on pandoc for RUN_DEPENDS
I've seen these two nits only now, but I'm not familiar with the python
infrastructure in ports so they may be wrong/opinable:
- comment starts with uppercase; also maybe specify that's a python
wrapper?
- use ``py-wheel${MODPY_FLAVOR}'' instead of ``py-wheel,python3''
If by any chance I'm not wrong, here's an updated tarball.
Cheers!
py-pypandoc.tgz
Description: Binary data
