> > Port-wise I've bumped SHARED_LIBS and added pkg/README to mention
> > ffmpeg for extra format support. This will result in a leaner port
> > as submitted before.
> 
> Not sure I understand the readme. The only mention of FFmpeg in the
> distribution is this:
> 
> ./TODO:  - Using (unreleased) ffmpeg driver:
> ./TODO:    - ./ffmpeg -i movie.mkv -pix_fmt rgba -f chafa -color 16
> -symbols vhalf,space -fill ascii -

I did try to play a video file with chafa and got the following error:

openbsd-ports$ chafa video.mpg                                                  
                                                                                
                                              
chafa: Error loading 'video.mpg': delegate failed `'ffmpeg' -nostdin -v -1 -i 
'%i' -vframes %S -vcodec pam -an -f rawvideo -y '%u.pam' 2> '%u'' @ 
error/delegate.c/InvokeDelegate/1978

After installing FFmpeg I could display the video. If my phrasing is
difficult to understand, I will rephrase it.

> Looks like it should only be a minor rather than major shared library
> bump?

I did compare the old and the new library according to the
instructions described here.[1]

openbsd-ports$ diff chafaold.txt chafanew.txt                                   
                                                                                
                                              
14a15
> T chafa_canvas_config_get_fg_only_enabled
33a35
> T chafa_canvas_config_set_fg_only_enabled
43a46,48
> T chafa_canvas_get_char_at
> T chafa_canvas_get_colors_at
> T chafa_canvas_get_raw_colors_at
48a54,55
> T chafa_canvas_set_char_at
> T chafa_canvas_set_colors_at
49a57
> T chafa_canvas_set_raw_colors_at
73a82,84
> T chafa_term_info_emit_begin_iterm2_image
> T chafa_term_info_emit_begin_kitty_image_chunk
> T chafa_term_info_emit_begin_kitty_immediate_image_v1
98a110,112
> T chafa_term_info_emit_end_iterm2_image
> T chafa_term_info_emit_end_kitty_image
> T chafa_term_info_emit_end_kitty_image_chunk

I was unsure so I bumped major shared library. If this only warrants a
minor bump, I will correct that.

Thanks!

[1] https://www.openbsd.org/faq/ports/specialtopics.html#SharedLibs

-- 
greetings,

Florian Viehweger

Reply via email to