Hi Stuart, On Mon, Sep 13, 2021 at 03:57:00PM +0100, Stuart Henderson wrote: > On 2021/09/13 12:23, Edd Barrett wrote: > > - Therefore, Neovim upstream uses a hard-coded LuaJIT commit and > > statically embeds. > > Which branch does it take this from? I had a quick look at their repo > but I didn't find any version of luajit either directly or via submodule, > might have missed something though..
Their cmake build system downloads a load of stuff, including LuaJIT (obviously I'll have to work around this in porting -- perhaps rolling my own LuaJIT distfile, but anyway): ``` $ grep LUAJIT_URL third-party/CMakeLists.txt set(LUAJIT_URL https://github.com/LuaJIT/LuaJIT/archive/787736990ac3b7d5ceaba2697c7d0f58f77bb782.tar.gz) ``` That's a commit from March this year which does indeed appear to be on the 2.1 branch. > If it's from the 2.1 branch (supporting > more arches, including aarch64 which I regard as fairly important) then > I think it would probably make sense to go with that 'blessed' version, > it is clearly what neovim expects to be using. It should mean that it works on aarch64, yes. The Neovim devs mentioned that this is one of the reasons for using that branch. So to be clear, you are in favour of statically linking this LuaJIT version into Neovim? -- Best Regards Edd Barrett https://www.theunixzoo.co.uk
