> On Sep 12, 2021, at 9:57 AM, Stefan Hagen <sh+openbsd-po...@codevoid.de>
> wrote:
>
> Stuart Henderson wrote:
>>> On 2021/09/12 07:35, Daniel Dickman wrote:
>>> Can take a look if no one beats me to it but one question below.
>>>
>>>> On Sep 12, 2021, at 3:22 AM, Stefan Hagen <sh+openbsd-po...@codevoid.de>
>>>> wrote:
>>>>
>>>> *ping*
>>>>
>>>> Stefan Hagen wrote:
>>>>> Stefan Hagen wrote:
>>>>>> Stefan Hagen wrote:
>>>>>>> Updated version below with the following changes:
>>>>>>>
>>>>>>> * dropped MESSAGE (outdated)
>>>>>>> * dropped ONLY_FOR_ARCHS
>>>>>>> * brought back your patch-src_base_detect_h which fixes BE archs
>>>>>>> * put myself into the maintainer seat
>>>>
>>>>
>>>> -MODULES= lang/python
>>>> -MODPY_VERSION = ${MODPY_DEFAULT_VERSION_2}
>>>> +FLAVORS= python3
>>>> +FLAVOR= python3
>>>> +
>>>>
>>>
>>> Why switch to a flavored port? For leaf ports (like games) it’s probably
>>> not needed.
>>
>> Yes this should not be flavoured, that is only for ports providing
>> python modules. Stand-alone software (e.g. equivalent to lua ports using
>> MODLUA_SA) which just happens to have some bits using Python don't use it.
>>
>
> Thanks. I thought this is the new way of setting the python version as
> this was mentioned on other ports. I didn't catch that this is only for
> python modules.
>
> I reverted this bit back to:
> MODPY_VERSION = ${MODPY_DEFAULT_VERSION_3}
Actually you should just drop this line as that’s already the default.
(Try “make show= MODPY_VERSION” from the shell with and without that line)
