On Tue, Aug 03, 2021 at 10:00:35AM +1000, Colin Tree wrote: > Hi, > > I have a minor change to the u-boot port > > to enable support for FriendlyElec NanoPC - T4 > > to reflect Supported Devices in arm64/INSTALL.arm64.
A mention in INSTALL does not mean firmware is also provided in ports. > > it only changes Makefile and pkg/PFRAG.aarch64. > > > Go well, > > Colin As this is the same patch you sent me off list a few months ago the same comments apply. Have you tried this via serial? I would expect a patch to configs/nanopc-t4-rk3399_defconfig for -CONFIG_BAUDRATE=1500000 +CONFIG_BAUDRATE=115200 for U-Boot to show at the same rate as ATF/OpenBSD. The dts change appears to be covered by the existing patch-arch_arm_dts_rk3399-nanopi4_dtsi rk3399-nanopc-t4.dts includes rk3399-nanopi4.dtsi > --- Makefile.orig 2021-07-08 03:18:39.000000000 +1000 > +++ Makefile 2021-08-03 09:38:32.075115125 +1000 > @@ -4,7 +4,7 @@ > BROKEN-arm= lib/time.c:187:1: internal compiler error: Bus error > > FLAVORS= aarch64 arm riscv64 > -FLAVOR?= arm > +FLAVOR?= aarch64 The default flavor should not be changed here. Set FLAVOR in your environment to build the aarch64 flavor. > > COMMENT= U-Boot firmware > VERSION= 2021.07 REVISION= 0 is needed as this changes the package > @@ -75,6 +75,7 @@ > firefly-rk3399 \ > mvebu_espressobin-88f3720 \ > mvebu_mcbin-88f8040 \ > + nanopc-t4-rk3399 \ whitespace is wrong here > nanopi-neo4-rk3399 \ > pinebook-pro-rk3399 \ > qemu_arm64 \
