On 2021/07/29 11:47, Stuart Henderson wrote: > On 2021/07/29 09:55, Yifei Zhan wrote: > > Hi, > > > > This patch updates ack from 3.3.1 to 3.5.0, with a small cosmetic change > > to keep spacing consistent. A few test cases failed but that's > > consistent with the old version.
oh, all tests are successful here, which failed for you? ===> Regression tests for p5-ack-3.5.0 Manifying 1 pod document "/usr/bin/perl" t/runtests.pl 0 0 "blib/lib" "blib/arch" t/*.t Running tests on blib/script/ack, ACK_TEST_STANDALONE=0 # Testing ack v3.5.0 under Perl v5.32.1, /usr/bin/perl # Using File::Next 1.18 # Using File::Spec 3.78 # Using Getopt::Long 2.51 # Using Pod::Perldoc 3.2801 # Using Pod::Text 4.14 # Using Pod::Usage 1.69 # Using Term::ANSIColor 5.01 # Using Test::Harness 3.42 # Using Test::More 1.302175 # PATH=/usr/obj/ports/p5-ack-3.5.0/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11R6/bin t/00-load.t .................. ok t/ack-1.t .................... ok t/ack-c.t .................... ok t/ack-color.t ................ ok t/ack-column.t ............... ok t/ack-f.t .................... ok t/ack-files-from.t ........... ok t/ack-g.t .................... ok t/ack-group.t ................ ok t/ack-h.t .................... ok t/ack-help-types.t ........... ok t/ack-help.t ................. ok t/ack-i.t .................... ok t/ack-ignore-dir.t ........... ok t/ack-ignore-file.t .......... ok t/ack-k.t .................... ok t/ack-l.t .................... ok t/ack-m.t .................... ok # 1087 t/ack-man.t .................. ok t/ack-match.t ................ ok t/ack-n.t .................... ok t/ack-o.t .................... ok t/ack-output.t ............... ok t/ack-pager.t ................ ok t/ack-passthru.t ............. ok t/ack-print0.t ............... ok t/ack-proximate.t ............ ok t/ack-Q.t .................... ok cannot chdir to child for /tmp/CZnTVM5mRB/foo: Permission denied at /usr/libdata/perl5/File/Temp.pm line 2628. cannot remove directory for /tmp/CZnTVM5mRB: Directory not empty at /usr/libdata/perl5/File/Temp.pm line 2628. t/ack-s.t .................... ok t/ack-show-types.t ........... ok t/ack-type-del.t ............. ok t/ack-type.t ................. ok t/ack-underline.t ............ ok t/ack-v.t .................... ok t/ack-w.t .................... ok t/ack-x.t .................... ok t/anchored.t ................. ok t/bad-ackrc-opt.t ............ ok t/basic.t .................... ok t/command-line-files.t ....... ok t/config-backwards-compat.t .. ok t/context-with-newlines.t .... ok t/context.t .................. ok t/double-hyphen.t ............ ok t/empty-lines.t .............. ok t/exit-code.t ................ ok t/file-permission.t .......... ok t/filetype-detection.t ....... ok t/filetypes.t ................ ok t/forbidden-options.t ........ ok t/from-stdin.t ............... ok t/highlighting.t ............. ok t/illegal-regex.t ............ ok t/incomplete-last-line.t ..... ok t/interactive.t .............. ok t/invalid-ackrc.t ............ ok t/invalid-options.t .......... ok t/inverted-file-filter.t ..... ok t/line-endings.t ............. ok t/longopts.t ................. ok t/multiple-captures.t ........ ok t/mutex-options.t ............ ok t/named-pipes.t .............. ok t/needs-line-scan.t .......... ok t/noackrc.t .................. ok t/prescan-line-boundaries.t .. ok t/process-substitution.t ..... ok t/trailing-whitespace.t ...... ok t/zero.t ..................... ok All tests successful. Files=69, Tests=857, 108 wallclock secs ( 0.57 usr 0.22 sys + 87.95 cusr 19.96 csys = 108.70 CPU) Result: PASS "/usr/bin/perl" squash ack lib/App/Ack.pm lib/App/Ack/ConfigDefault.pm lib/App/Ack/ConfigFinder.pm lib/App/Ack/ConfigLoader.pm lib/App/Ack/File.pm lib/App/Ack/Files.pm lib/App/Ack/Filter.pm lib/App/Ack/Filter/Collection.pm lib/App/Ack/Filter/Default.pm lib/App/Ack/Filter/Extension.pm lib/App/Ack/Filter/ExtensionGroup.pm lib/App/Ack/Filter/FirstLineMatch.pm lib/App/Ack/Filter/Inverse.pm lib/App/Ack/Filter/Is.pm lib/App/Ack/Filter/IsGroup.pm lib/App/Ack/Filter/IsPath.pm lib/App/Ack/Filter/IsPathGroup.pm lib/App/Ack/Filter/Match.pm lib/App/Ack/Filter/MatchGroup.pm File::Next > ack-standalone Reading ack Reading lib/App/Ack.pm Reading lib/App/Ack/ConfigDefault.pm Reading lib/App/Ack/ConfigFinder.pm Reading lib/App/Ack/ConfigLoader.pm Reading lib/App/Ack/File.pm Reading lib/App/Ack/Files.pm Reading lib/App/Ack/Filter.pm Reading lib/App/Ack/Filter/Collection.pm Reading lib/App/Ack/Filter/Default.pm Reading lib/App/Ack/Filter/Extension.pm Reading lib/App/Ack/Filter/ExtensionGroup.pm Reading lib/App/Ack/Filter/FirstLineMatch.pm Reading lib/App/Ack/Filter/Inverse.pm Reading lib/App/Ack/Filter/Is.pm Reading lib/App/Ack/Filter/IsGroup.pm Reading lib/App/Ack/Filter/IsPath.pm Reading lib/App/Ack/Filter/IsPathGroup.pm Reading lib/App/Ack/Filter/Match.pm Reading lib/App/Ack/Filter/MatchGroup.pm Reading /usr/local/libdata/perl5/site_perl/File/Next.pm "/usr/bin/perl" -MExtUtils::MY -e 'MY->fixin(shift)' -- ack-standalone "/usr/bin/perl" -c ack-standalone ack-standalone syntax OK "/usr/bin/perl" t/runtests.pl 1 0 "blib/lib" "blib/arch" t/*.t Running tests on ack-standalone, ACK_TEST_STANDALONE=1 # Testing ack v3.5.0 under Perl v5.32.1, /usr/bin/perl # Using File::Next 1.18 # Using File::Spec 3.78 # Using Getopt::Long 2.51 # Using Pod::Perldoc 3.2801 # Using Pod::Text 4.14 # Using Pod::Usage 1.69 # Using Term::ANSIColor 5.01 # Using Test::Harness 3.42 # Using Test::More 1.302175 # PATH=/usr/obj/ports/p5-ack-3.5.0/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11R6/bin t/00-load.t .................. ok t/ack-1.t .................... ok t/ack-c.t .................... ok t/ack-color.t ................ ok t/ack-column.t ............... ok t/ack-f.t .................... ok t/ack-files-from.t ........... ok t/ack-g.t .................... ok t/ack-group.t ................ ok t/ack-h.t .................... ok t/ack-help-types.t ........... ok t/ack-help.t ................. ok t/ack-i.t .................... ok t/ack-ignore-dir.t ........... ok t/ack-ignore-file.t .......... ok t/ack-k.t .................... ok t/ack-l.t .................... ok t/ack-m.t .................... ok # 1087 t/ack-man.t .................. ok t/ack-match.t ................ ok t/ack-n.t .................... ok t/ack-o.t .................... ok t/ack-output.t ............... ok t/ack-pager.t ................ ok t/ack-passthru.t ............. ok t/ack-print0.t ............... ok t/ack-proximate.t ............ ok t/ack-Q.t .................... ok cannot chdir to child for /tmp/d3gcSvxVpb/foo: Permission denied at /usr/libdata/perl5/File/Temp.pm line 2628. cannot remove directory for /tmp/d3gcSvxVpb: Directory not empty at /usr/libdata/perl5/File/Temp.pm line 2628. t/ack-s.t .................... ok t/ack-show-types.t ........... ok t/ack-type-del.t ............. ok t/ack-type.t ................. ok t/ack-underline.t ............ ok t/ack-v.t .................... ok t/ack-w.t .................... ok t/ack-x.t .................... ok t/anchored.t ................. ok t/bad-ackrc-opt.t ............ ok t/basic.t .................... ok t/command-line-files.t ....... ok t/config-backwards-compat.t .. ok t/context-with-newlines.t .... ok t/context.t .................. ok t/double-hyphen.t ............ ok t/empty-lines.t .............. ok t/exit-code.t ................ ok t/file-permission.t .......... ok t/filetype-detection.t ....... ok t/filetypes.t ................ ok t/forbidden-options.t ........ ok t/from-stdin.t ............... ok t/highlighting.t ............. ok t/illegal-regex.t ............ ok t/incomplete-last-line.t ..... ok t/interactive.t .............. ok t/invalid-ackrc.t ............ ok t/invalid-options.t .......... ok t/inverted-file-filter.t ..... ok t/line-endings.t ............. ok t/longopts.t ................. ok t/multiple-captures.t ........ ok t/mutex-options.t ............ ok t/named-pipes.t .............. ok t/needs-line-scan.t .......... ok t/noackrc.t .................. ok t/prescan-line-boundaries.t .. ok t/process-substitution.t ..... ok t/trailing-whitespace.t ...... ok t/zero.t ..................... ok All tests successful. Files=69, Tests=857, 104 wallclock secs ( 0.58 usr 0.24 sys + 86.79 cusr 18.01 csys = 105.62 CPU) Result: PASS