On 2021/07/16 09:02, Stefan Hagen wrote:
> Stefan Hagen wrote:
> > Denis is right too. Even with that line changed, flameshot.1 ends up in
> > share/man. I tried fixing it without success. Therefore my proposal is
> > to move it post-install.

Hmm. With that line changed I don't get a file in
${PREFIX}/share/man/man1. But now I look again I don't get a file in
${PREFIX}/man/man1 either, it's just copying to the build directory
there.

> So this would be my hacky patch that moves the manpage via cmake.
> I think both solutions are fine.
> 
> $OpenBSD$
> 
> Install manpage to correct location
> 
> Index: src/CMakeLists.txt
> --- src/CMakeLists.txt.orig
> +++ src/CMakeLists.txt
> @@ -264,7 +264,7 @@ configure_file(${CMAKE_SOURCE_DIR}/data/dbus/org.flame
>  
>  # Install man pages
>  configure_file(${CMAKE_SOURCE_DIR}/data/man/man1/flameshot.1
> -        ${CMAKE_CURRENT_BINARY_DIR}/share/man/man1/flameshot.1 COPYONLY)
> +        ${CMAKE_CURRENT_BINARY_DIR}/man/man1/flameshot.1 COPYONLY)
>  
>  # Install Icons
>  
> configure_file(${CMAKE_SOURCE_DIR}/data/img/hicolor/48x48/apps/org.flameshot.Flameshot.png
> @@ -287,6 +287,7 @@ configure_file(${CMAKE_SOURCE_DIR}/data/img/hicolor/sc
>          
> ${CMAKE_CURRENT_BINARY_DIR}/share/icons/hicolor/scalable/apps/flameshot.svg 
> COPYONLY)
>  
>  # Install assets
> +install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/man/ DESTINATION 
> ${CMAKE_INSTALL_PREFIX}/man)

right so that's the  missing piece. This is the correct approach.

>  install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/share/ DESTINATION 
> ${CMAKE_INSTALL_DATAROOTDIR})
>  
>  # Install Translations

Reply via email to