On Tue, Jul 13 2021, Charlene Wendling <juliana...@posteo.jp> wrote:
> On Tue, 13 Jul 2021 01:51:28 +0200
> Jeremie Courreges-Anglas <j...@openbsd.org> wrote:
>
>> On Mon, Jul 12 2021, Charlene Wendling <juliana...@posteo.jp> wrote:
>> > Hi,
>> >
>> > This is the first bulk with base libexecinfo.
>> >
>> >> https://bin.charlenew.xyz/emacs_bulk_failure.log
>> >
>> > The last port commit brought libexecinfo support to emacs, and
>> > leads to segfault during the build on macppc. I attach the
>> > backtrace of a simple 'temacs' invocation, showing that it may not
>> > be emacs' fault.
>> >
>> > I can't fix the libexecinfo issue.
>> >
>> > But the build works fine with the below diff [0] [1] [2]. It reverts
>> > the latest commit on macppc, while leaving the other arches as it
>> > is currently. As such no REVISION bump is needed.
>> >
>> > Comments/feedback are welcome,
>> 
>> ok jca@ for this diff but please amend the comment unless you're sure
>> the problem comes from Lisp code.  AFAIK the emacs C code calls
>> backtrace() early.  I'd suggest
>> 
>>   # backtrace() crashes at build time on powerpc
>
> I'm not sure, so i'll change the comment.
>
>> I'm slightly worried regarding libunwind status on powerpc.  What does
>> regress/gnu/lib/libexecinfo say?
>
> This cannot be run on macppc:
>
> -->8--
> ==== run-regress-skiparch ====
> # No unwind info on this arch
> SKIPPED
> --8<--
>
> It's limited to amd64 or llvm>=12, as mentioned in the regress'
> Makefile cvs log.

Well could you please test with the diff below applied?


Index: Makefile
===================================================================
RCS file: /d/cvs/src/regress/gnu/lib/libexecinfo/Makefile,v
retrieving revision 1.2
diff -u -p -r1.2 Makefile
--- Makefile    18 Jun 2021 14:09:31 -0000      1.2
+++ Makefile    13 Jul 2021 11:49:56 -0000
@@ -6,7 +6,7 @@
 
 # Only amd64 has unwind info by default in llvm11. llvm12 adds more arches.
 CLANG_VERSION!=clang --version | head -1 | grep -E -o 'version [[:digit:]]+' | 
cut -d' ' -f 2
-CLANG_GE_12!=if [ ${CLANG_VERSION} -ge 12 ] ; then echo 1 ; fi
+CLANG_GE_12!=if [ ${CLANG_VERSION} -ge 11 ] ; then echo 1 ; fi
 .if ${MACHINE} == "amd64" || ${CLANG_GE_12} == "1"
 
 PROG=  t_backtrace

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE

Reply via email to