On Wed, May 26, 2021 at 10:13:44PM +1000, Jonathan Matthew wrote: > On Mon, May 24, 2021 at 05:07:12PM +0100, Stuart Henderson wrote: > > danj pointed out https://ferd.ca/you-ve-got-to-upgrade-rebar3.html; > > here's an update for the port to a version which both has a fix for this, > > and still supports erlang 21 (3.15.x support OTP 19 to 23; 3.16.x > > supports 22 to 24). > > Thanks for looking at this. > > > > > while there I fixed the distfile name from the current bare version > > number, and got tests to work. > > > > i think the existing patches to change these ... > > > > - "$BINDIR/erl" -boot start_clean \ > > + "$BINDIR/erl${ERL_VERSION}" -boot start_clean \ > > > > in relx_get_nodename() etc are incorrect, BINDIR refers to > > /usr/local/lib/erlang21/erts-10.2/bin where the files have no version > > suffix, so i've dropped those. (of course I've kept the patches for > > filenames searched in the default PATH). > > I'm a bit confused about this. BINDIR can also be the erts/bin > directory of a release generated by rebar3/relx, and in those, the erl > binary does have the version suffix. I'm not sure how it gets there. > I'll look into this more.
Turns out I did this myself, which of course indicates the patches are wrong and should be dropped. > > > > > the test suite passes, but i'm not really a user of this, so a > > real-world test is probably a good idea. > > My main use for rebar3 is building current versions of databases/riak > (not yet in the ports tree), and last time I tried, it didn't work with > newer versions of rebar3. I may be able to find something else. I've compiled some other stuff with this update and it all works ok. ok jmatthew@
