On 2021/04/21 11:24, Renaud Allard wrote:
> Hello,
>
> This diff updates net/mautrix-whatsapp to v0.1.6. It now has release numbers
> unlike when it was first ported. It is also now using portgen instead of a
> custom tarball.
>
> Best Regards
> Index: Makefile
> ===================================================================
> RCS file: /cvs/ports/net/mautrix-whatsapp/Makefile,v
> retrieving revision 1.3
> diff -u -p -r1.3 Makefile
> --- Makefile 8 Mar 2021 13:59:25 -0000 1.3
> +++ Makefile 21 Apr 2021 09:21:21 -0000
> @@ -2,14 +2,13 @@
>
> COMMENT = matrix-WhatsApp puppeting bridge
>
> -V = 20200327
> -COMMIT = 3a9642386cdff8293657c8409da4bffd674184bf
> -DISTNAME = mautrix-whatsapp-${V}
> -REVISION = 0
> -
> -# warning, for the .tar.gz, "go mod vendor" is not sufficient
> -# you need to clone https://github.com/chai2010/webp and
> -# copy webp/internal into vendor/github.com/chai2010/webp/
> +GH_ACCOUNT = tulir
> +GH_PROJECT = mautrix-whatsapp
> +GH_TAGNAME = v0.1.6
> +
> +V = 0.1.6
> +COMMIT = f9098cdf182bf4aaead393326167fb636df60967
What is "COMMIT" used for?
> -PERMIT_PACKAGE = Yes
> +PERMIT_PACKAGE = yes
ports standard is Yes
> +# Lines below not in the template
please remove that comment
> +MODGO_MODNAME = maunium.net/go/mautrix-whatsapp
please don't hide that in the middle of the big chunk of
MODGO_MODFILES/MODGO_MODULES, up the top with GH_* would be good
> + sigs.k8s.io/yaml v1.1.0
> \
> + sourcegraph.com/sourcegraph/appdash
> v0.0.0-20190731080439-ebfcffb1b5c0
> +MODGO_VERSION = v0.1.6
> +PERMIT_DISTFILES = unknown license
> +PKGNAME = mautrix-whatsapp-0.1.6
those should be up top too, but MODGO_VERSION=${GH_TAGNAME} would be better,
I think it will set that PKGNAME by default too, and can you check on that
"unknown license" because there isn't much that would result in disabling
distfiles that would not also disable packages
(ports remains locked btw)
