On Sun, 11 Apr 2021 09:33:37 +0200, Denis Fondras <open...@ledeuns.net>
wrote:

> Here is an update to the "latest" version of MinIO.

Thanks for working on it! A few comments inline.

> Can someone test on aarch64 to check if BROKEN can be removed ?

Given they use a recent version of x/sys/unix, it should be fine.

> Denis
> 
> Index: Makefile.inc
> ===================================================================
> RCS file: /cvs/ports/net/minio/Makefile.inc,v
> retrieving revision 1.5
> diff -u -p -r1.5 Makefile.inc
> --- Makefile.inc      28 Dec 2019 14:35:35 -0000      1.5
> +++ Makefile.inc      10 Apr 2021 19:45:05 -0000

[...]

> +MAINTAINER = OpenBSD ports list <ports@openbsd.org>
> +

no need for that

> Index: client/Makefile
> ===================================================================
> RCS file: /cvs/ports/net/minio/client/Makefile,v retrieving revision
> 1.26 diff -u -p -r1.26 Makefile
> --- client/Makefile   8 Mar 2021 13:59:25 -0000       1.26
> +++ client/Makefile   10 Apr 2021 19:45:05 -0000
> @@ -1,15 +1,702 @@

> +V =          20210407192553
> +
> +MODGO_MODNAME =      github.com/minio/mc
> +MODGO_VERSION =      v0.0.0-${V}-438028824990
> +
>

This is using a random commit from upstream, isn't it? Would it be
possible to use a release/tag instead?


Did you try login through the web interface? Here it fails with "Invalid
UI version in the JSON-RPC response". That said my mastodon instance
seems to be able to upload content, which is the only thing that I care
about :)

Also it would be nice to have this in 6.9 given how the in-tree version
lags and has security problems. (and to have some packages on arm64)

Cheers,
Daniel

Reply via email to