Florian Viehweger <open...@out-of-creativity.de> writes:
> Am Fri, 09 Apr 2021 14:37:35 +0200 > schrieb Omar Polo <o...@omarpolo.com>: > >> >> k...@openbsd.org writes: >> >> > http://build-failures.rhaalovely.net/sparc64/2021-04-06/net/vger.log >> >> This should fix the build with gcc > > Thank you for looking at this. > > This compiles for me on amd64 and I've done (light) testing. > > Can anybody with working sparc64 hardware please test this? I don't have a spark, but you can replicate with `CC=gcc make'. On amd64 the default c compiler is clang, but it's not the case for every arch. Moreover, the gcc version in base is quite old and doesn't support C99 OOTB (hence the need for the -std=gcc99 flag) - I may remember wrong tho. I added the CFLAGS without wrapping it with some .if because a quick grep showed other ports doing the same (I remember graphics/feh in particular), don't know if there are better ways. Cheers :) > Attached is a modified diff with added REVISION. > > Thank you! > > > Index: Makefile > =================================================================== > RCS file: /cvs/ports/net/vger/Makefile,v > retrieving revision 1.1.1.1 > diff -u -p -u -p -r1.1.1.1 Makefile > --- Makefile 4 Apr 2021 08:57:15 -0000 1.1.1.1 > +++ Makefile 9 Apr 2021 19:46:07 -0000 > @@ -5,6 +5,7 @@ V = 1.06 > DISTNAME = vger-${V} > > CATEGORIES = net > +REVISION = 0 > > HOMEPAGE = https://tildegit.org/solene/vger/ > > @@ -20,5 +21,7 @@ WANTLIB += c > MASTER_SITES = https://tildegit.org/solene/vger/archive/ > DISTFILES = vger-{}${V}${EXTRACT_SUFX} > WRKSRC = ${WRKDIR}/vger > + > +CFLAGS += -std=gnu99 > > .include <bsd.port.mk>
